Skip to content

Fix POSIX ioctls on big-endian systems (s390x for example)#104

Merged
puddly merged 4 commits into
puddly:devfrom
EdwardBetts:dev
Jun 12, 2026
Merged

Fix POSIX ioctls on big-endian systems (s390x for example)#104
puddly merged 4 commits into
puddly:devfrom
EdwardBetts:dev

Conversation

@EdwardBetts

Copy link
Copy Markdown
Contributor

I've made a Debian package for serialx, the package is available here: https://tracker.debian.org/pkg/python-serialx

Debian runs on lots of architectures including s390x. The s390x architecture is interesting because it is big-endian, there aren't many big-endian architectures left. The Debian CI infrastructure identified endian related bugs when running the tests on s390x.

I've modified the code to fix these bugs and serialx now runs happily on the s390x architecture.

Just to warn you I did get assistance from a coding agent when writing this fix. I don't know if you have a policy about AI contributions, but I thought it was important to let you know.

Comment thread tests/test_serial_posix.py Outdated
Comment thread tests/test_serial_posix.py Outdated
EdwardBetts and others added 2 commits June 12, 2026 16:30
Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
@puddly

puddly commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Thanks! I haven't run into endianness issues in a long while 😄.

Just to warn you I did get assistance from a coding agent when writing this fix. I don't know if you have a policy about AI contributions, but I thought it was important to let you know.

As long as you've tested it (or it passes some form of CI) there's no issues at all. This is a pretty small PR.

@puddly

puddly commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Looks like little endian CI passes so this should be good to go.

My apologies for the linter failure, I forgot to update our README to include this step:

uv pip install '.[dev]'
prek run --all-files

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.35%. Comparing base (4a1818c) to head (9274335).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #104      +/-   ##
==========================================
+ Coverage   92.15%   92.35%   +0.19%     
==========================================
  Files          22       22              
  Lines        3660     3661       +1     
==========================================
+ Hits         3373     3381       +8     
+ Misses        287      280       -7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly puddly enabled auto-merge (squash) June 12, 2026 15:46
@puddly puddly merged commit 5b4fd47 into puddly:dev Jun 12, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants