Skip to content

Fully drain RFC2217 on graceful close#100

Merged
puddly merged 4 commits into
devfrom
puddly/fix-flaky-ser2net-test
Jun 8, 2026
Merged

Fully drain RFC2217 on graceful close#100
puddly merged 4 commits into
devfrom
puddly/fix-flaky-ser2net-test

Conversation

@puddly

@puddly puddly commented Jun 8, 2026

Copy link
Copy Markdown
Owner

This fixes the flaky RFC2217 test that we've been seeing by aligning close semantics for RFC2217 with that of other backends. There is no form of backpressure or flow control but we get around it by using TCP and enqueuing a no-op command with a simple response upon close: when we receive a response, we know all previous data has been sent out and are good to close. abort should work as before.

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (f9f1bf2) to head (1936940).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #100      +/-   ##
==========================================
+ Coverage   92.23%   92.27%   +0.03%     
==========================================
  Files          22       22              
  Lines        3632     3649      +17     
==========================================
+ Hits         3350     3367      +17     
  Misses        282      282              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly puddly merged commit 454145e into dev Jun 8, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant