Conversation
Contributor
Author
SummaryUpgrades the frontend ( This was previously waiting on an What changed
Diff noteThe bulk of the line count is mechanical: the VerificationAll run on the full Angular 22 + angular-eslint 22 toolchain:
Follow-ups (not in this PR)
|
And typescript 6
motionduck
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the frontend (
app/mikane) from Angular 21.2.8 to 22.0.0, run via theofficial
ng updateschematics. Also bumps TypeScript 5.9 → 6.0 (required byAngular 22).
angular-eslintships a v22 release. The@angular-eslint/*packages are pinned at21.4.0(latest available) againstAngular 22 core. Lint passes, but I'd rather align the toolchain before merging
than land a known version skew.
What changed
@angular/*21.2.8 → 22.0.0,@angular/cdk/@angular/material→ 22.0.0typescript^5.9.3→^6.0.3withXhr()toprovideHttpClient(main.ts). Angular 22 makes fetch the default
backend;
withXhr()preserves the existing XHR behavior so nothing breaks.ChangeDetectionStrategy.Eagerto 44 components. In v22 the old
Default(CheckAlways) is deprecated andrenamed to
Eager— same enum value, identical behavior, no perf change.baseUrl(no longer an allowed field) and the now-invalidnoUnusedLocals. DroppingbaseUrlis why everysrc/...import was rewrittento a relative path — this accounts for the bulk of the diff. Unused-locals
coverage is retained via
@typescript-eslint/no-unused-vars: "error".Diff note
144 files / +2793 −2289 looks large but is ~95% mechanical: the
src/...→relative-import rewrite plus prettier reflow. The only behavioral lines to
review are the
withXhr()andEagerchanges described above.Verification
npm run build— clean (5.3s, no warnings)npm run lint— all files passnpm run test— 561/561 pass (66 files)Follow-ups (not in this PR)
withXhr()for the fetch backend (only blocker is uploadprogress reporting — verify the avatar upload flow first).
Eager/CheckAlwayscomponents are acandidate for incremental migration to signal-based
OnPush.