fix: Improve broken mobile payment dropdown#503
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR addresses a broken mobile payment dropdown expand behavior, updates default currency formatting for EUR, and tweaks footer text.
Changes:
- Update
AppCurrencyPipedefaults (EUR localede-DE, default currency displaysymbol) and relax a brittle assertion in its unit test. - Refactor mobile
PaymentItemComponentdropdown height/animation handling using signals and a transition suppression flag. - Update footer text to include a
vprefix and remove the “Developed by …” line.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| app/mikane/src/app/shared/currency/app-currency.pipe.ts | Changes EUR locale mapping and default currency display mode. |
| app/mikane/src/app/shared/currency/app-currency.pipe.spec.ts | Adjusts USD assertion to allow runtime Intl differences. |
| app/mikane/src/app/features/mobile/payment-item/payment-item.component.ts | Reworks dropdown open/close height calculation with timers + transition suppression. |
| app/mikane/src/app/features/mobile/payment-item/payment-item.component.spec.ts | Updates tests to drive expanded input and uses fake timers deterministically. |
| app/mikane/src/app/features/mobile/payment-item/payment-item.component.scss | Adds .no-transition modifier to suppress height transitions. |
| app/mikane/src/app/features/mobile/payment-item/payment-item.component.html | Binds height to a signal and applies .no-transition class conditionally. |
| app/mikane/src/app/features/footer/footer.component.html | Updates footer copy/formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aydex
approved these changes
Jun 5, 2026
- plus a minor currency pipe adjustment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog:
Closes #497