Skip to content

fix: Improve broken mobile payment dropdown#503

Merged
motionduck merged 1 commit into
developfrom
expand-toggle
Jun 5, 2026
Merged

fix: Improve broken mobile payment dropdown#503
motionduck merged 1 commit into
developfrom
expand-toggle

Conversation

@motionduck

Copy link
Copy Markdown
Member

Changelog:

  • Fix mobile payment expand not triggering correctly
  • Change currency pipe's EUR locale to de-DE, and default display to 'symbol'
  • Slight change in footer text

Closes #497

@motionduck motionduck added this to the 2.6.0 milestone Jun 5, 2026
@motionduck motionduck self-assigned this Jun 5, 2026
@motionduck motionduck added bug Something isn't working frontend labels Jun 5, 2026
@motionduck motionduck requested a review from Copilot June 5, 2026 15:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR addresses a broken mobile payment dropdown expand behavior, updates default currency formatting for EUR, and tweaks footer text.

Changes:

  • Update AppCurrencyPipe defaults (EUR locale de-DE, default currency display symbol) and relax a brittle assertion in its unit test.
  • Refactor mobile PaymentItemComponent dropdown height/animation handling using signals and a transition suppression flag.
  • Update footer text to include a v prefix and remove the “Developed by …” line.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
app/mikane/src/app/shared/currency/app-currency.pipe.ts Changes EUR locale mapping and default currency display mode.
app/mikane/src/app/shared/currency/app-currency.pipe.spec.ts Adjusts USD assertion to allow runtime Intl differences.
app/mikane/src/app/features/mobile/payment-item/payment-item.component.ts Reworks dropdown open/close height calculation with timers + transition suppression.
app/mikane/src/app/features/mobile/payment-item/payment-item.component.spec.ts Updates tests to drive expanded input and uses fake timers deterministically.
app/mikane/src/app/features/mobile/payment-item/payment-item.component.scss Adds .no-transition modifier to suppress height transitions.
app/mikane/src/app/features/mobile/payment-item/payment-item.component.html Binds height to a signal and applies .no-transition class conditionally.
app/mikane/src/app/features/footer/footer.component.html Updates footer copy/formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- plus a minor currency pipe adjustment
@motionduck motionduck merged commit 751525b into develop Jun 5, 2026
9 checks passed
@motionduck motionduck deleted the expand-toggle branch June 5, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile payment expand not triggering correctly

3 participants