Puavo school-scoped sharing via Nextcloud's native UI - #2
Merged
Merged
Conversation
Replace the old Vue + Puavo-API share-buttons UI with a backend-only
implementation that surfaces class groups in Nextcloud's native share
dialog (web, mobile, desktop). Teachers are recognised from puavo LDAP
(puavoEduPersonAffiliation=teacher) and authorised per-school via
puavoSchool; sharing across schools the teacher doesn't belong to is
rejected by the same Share20\Manager check that protects everyone else.
- OCP\GroupInterface backend virtualises (uid, school) -> class group
membership; the matching ISearchPlugin contributes those groups to
the picker.
- LdapSync uses paged Access::search{Users,Groups} with combined
filters — O(matches), not O(directory).
- Two app-owned tables: groupsharemachine_groups and
groupsharemachine_teachers (composite (uid, school_dn) PK).
- occ groupsharemachine:sync + 15-minute TimedJob; diagnose command.
- 42 PHPUnit tests, psalm clean, REUSE-compliant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite from the v0.0.1 Vue + Puavo-API share-buttons sidebar to a backend-only implementation that surfaces class groups in Nextcloud's native share dialog — so teachers can share to their classes from the web, mobile, and desktop clients without an app-specific UI.