Skip to content

fix(ci): add new handler files to compat-literals allowlist#357

Closed
ptone wants to merge 1 commit into
mainfrom
scion/ci-compat-literals-fix
Closed

fix(ci): add new handler files to compat-literals allowlist#357
ptone wants to merge 1 commit into
mainfrom
scion/ci-compat-literals-fix

Conversation

@ptone

@ptone ptone commented Jun 28, 2026

Copy link
Copy Markdown
Owner

…o to compat-literals allowlist

These files contain legitimate legacy grove literals for backward
compatibility (JSON unmarshaling, URL path fallbacks). Adding them
to the allowlist unblocks CI for multiple PRs.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'hack/check-project-compat-literals.sh' script to include 'pkg/hub/handlers_projects_core.go' and 'pkg/hub/handlers_runtime_brokers.go' in the 'allowed_paths' list. There are no review comments on this pull request, and I have no further feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ptone ptone closed this Jun 28, 2026
@ptone ptone deleted the scion/ci-compat-literals-fix branch June 28, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant