Include fortran files directly#1
Open
DWesl wants to merge 4 commits into
Open
Conversation
This should help code be more editable and encourage collaboration.
There does not seem to be overlap between the contents of the tarfiles. This brings the package in line with standard GitHub practice.
DWesl
force-pushed
the
include_files_directly
branch
from
c6d2ac8 to
a9daf6f
Compare
DWesl
commented
Mar 27, 2020
DWesl
left a comment
DWesl
left a comment
Author
There was a problem hiding this comment.
I noticed it wasn't lined up, and it started bothering me.
DWesl
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of including tar archives in the repository, include the files in those archives directly.
This makes it a bit easier for computers to find the files, and GitHub will still provide the option to download the whole thing as an InfoZip archive or gzip-compressed tar archive (
.zipor.tar.gzfiles, respectively).The compilation command is just a bit more complicated than
makenow, as eithermake -f Makefile_CTormake -f Makefile_GEOS.I also have an AutoTools-based build system, but that can wait for another PR.