feat(ios): enable the approved multicast networking entitlement#48
Conversation
Apple granted com.apple.developer.networking.multicast for this App ID, so Syncthing's local discovery can use multicast to find same-Wi-Fi peers directly instead of detouring through a relay. Add the entitlement to project.yml's generated entitlement properties (the source of truth) and the regenerated VaultSync.entitlements.
|
Warning Review limit reached
More reviews will be available in 6 minutes and 40 seconds. Learn how PR review limits work. To continue reviewing without waiting, enable usage-based billing in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Apple approved
com.apple.developer.networking.multicastfor this App ID — this enablesit in the app's entitlements.
Why: Syncthing's local peer discovery uses multicast. Without the entitlement iOS
blocks it, so same-Wi-Fi peers are only found via global discovery + direct dial
(slower, relay-prone). With it, local discovery works directly — completing the
local-network work from 1.7.0.
Changes:
ios/project.yml→ generatedentitlements.properties(source of truth) +regenerated
ios/VaultSync/VaultSync.entitlements.CHANGELOG.md→ 1.7.1 "Changed" note.No code or test changes.
Before the next App Store archive: the Distribution provisioning profile must
include the new entitlement — Xcode automatic signing refreshes it on archive; with
manual signing, regenerate and re-download the Distribution profile in the Developer
portal first.