chore(api): replace detect-secrets with kingfisher-bin to match the SDK#11698
Draft
danibarranqueroo wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Stacked on #11694 (replace
detect-secretswith Kingfisher in the SDK). The API installsprowlerfrom git (prowler @ git+...@master) and mirrors its dependency set in[tool.uv] constraint-dependencies, so once #11694 lands the API must dropdetect-secretsand pinkingfisher-binto stay aligned.Description
detect-secrets==1.5.0and addkingfisher-bin==1.104.0inapi/pyproject.toml([tool.uv] constraint-dependencies), matching the SDK pin. The API does not import the secret scanner directly — this only keeps the API's pinned dependency set consistent withprowler.api/uv.lockis not regenerated yet, so CI will be red until it is. The lock can only resolvekingfisher-bin(and fully dropdetect-secrets) onceprowler@mastercarries the SDK change — i.e. after #11694 merges. Finalize then with:GitHub will auto-retarget this PR to
masterwhen #11694 merges.Steps to review
kingfisher-bin==1.104.0).api/uv.lockand verify CI is green.Checklist
api/pyproject.tomldependency swapapi/uv.lockregenerated (after feat(sdk): replace detect-secrets library with kingfisher #11694 merges)