Skip to content

chore(api): replace detect-secrets with kingfisher-bin to match the SDK#11698

Draft
danibarranqueroo wants to merge 1 commit into
PROWLER-2083-replace-detect-secrets-library-with-a-new-onefrom
PROWLER-2083-api-kingfisher-dependency
Draft

chore(api): replace detect-secrets with kingfisher-bin to match the SDK#11698
danibarranqueroo wants to merge 1 commit into
PROWLER-2083-replace-detect-secrets-library-with-a-new-onefrom
PROWLER-2083-api-kingfisher-dependency

Conversation

@danibarranqueroo

Copy link
Copy Markdown
Member

Context

Stacked on #11694 (replace detect-secrets with Kingfisher in the SDK). The API installs prowler from git (prowler @ git+...@master) and mirrors its dependency set in [tool.uv] constraint-dependencies, so once #11694 lands the API must drop detect-secrets and pin kingfisher-bin to stay aligned.

Description

  • Remove detect-secrets==1.5.0 and add kingfisher-bin==1.104.0 in api/pyproject.toml ([tool.uv] constraint-dependencies), matching the SDK pin. The API does not import the secret scanner directly — this only keeps the API's pinned dependency set consistent with prowler.

⚠️ Blocked on #11694 — one remaining step

api/uv.lock is not regenerated yet, so CI will be red until it is. The lock can only resolve kingfisher-bin (and fully drop detect-secrets) once prowler@master carries the SDK change — i.e. after #11694 merges. Finalize then with:

cd api && uv lock
git add uv.lock && git commit -m "chore(api): regenerate uv.lock for kingfisher-bin"

GitHub will auto-retarget this PR to master when #11694 merges.

Steps to review

  1. Confirm the dependency swap matches the SDK (kingfisher-bin==1.104.0).
  2. After feat(sdk): replace detect-secrets library with kingfisher #11694 merges, regenerate api/uv.lock and verify CI is green.

Checklist

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 347150fd-9b16-4710-8cef-a2ca00df274d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch PROWLER-2083-api-kingfisher-dependency

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant