Skip to content

chore(ci): remove legacy prowler-api/ui/mcp cloud-deployment dispatch jobs#11644

Open
cesararroba wants to merge 1 commit into
masterfrom
chore/remove-legacy-cloud-deployment-dispatch
Open

chore(ci): remove legacy prowler-api/ui/mcp cloud-deployment dispatch jobs#11644
cesararroba wants to merge 1 commit into
masterfrom
chore/remove-legacy-cloud-deployment-dispatch

Conversation

@cesararroba

@cesararroba cesararroba commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Context

The trigger-deployment jobs in the api/ui/mcp container-build-push workflows fired repository_dispatch events (api-prowler-deployment, ui-prowler-deployment, mcp-prowler-deployment) to kick off the legacy cloud deployment workflows. Those cloud deployment workflows targeted dev stacks that have since been decommissioned, so these dispatch senders no longer have a receiver.

These container-build workflows are synced upstream (prowler → prowler-cloud), so the senders must be removed here too — leaving them in OSS prowler would re-introduce them on the next sync. The companion cloud-side removal is prowler-cloud PR #4691.

Description

Removes the trailing trigger-deployment job from each of the three container-build-push workflows:

  • .github/workflows/api-container-build-push.yml (api-prowler-deployment)
  • .github/workflows/mcp-container-build-push.yml (mcp-prowler-deployment)
  • .github/workflows/ui-container-build-push.yml (ui-prowler-deployment)

Each removed job was a leaf (needs: [setup, container-build-push]) with nothing depending on it, so no needs: rewiring was required. All other jobs (setup, notify-release-started, container-build-push, create-manifest, notify-release-completed) are untouched.

pr-merged.yml is intentionally left alone — it dispatches prowler-pull-request-merged (the PR-sync mechanism), not a deployment.

Steps to review

  • Confirm only the trigger-deployment job block is removed in each of the 3 files.
  • grep -rn 'trigger-deployment\|prowler-deployment' .github/workflows/ returns no matches.
  • pr-merged.yml's prowler-pull-request-merged dispatch is still present.
  • Each edited workflow still parses as valid YAML and retains its other jobs.

Checklist

  • Review if backport is needed. (CI-only change, no backport needed)

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Summary by CodeRabbit

  • Chores
    • Removed automated deployment triggers from CI/CD build workflows for container image builds.

@cesararroba cesararroba requested a review from a team as a code owner June 18, 2026 16:21
@github-actions github-actions Bot added the github_actions Pull requests that update GitHub Actions code label Jun 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ All necessary CHANGELOG.md files have been updated.

@github-actions

Copy link
Copy Markdown
Contributor

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: accec122-ae4f-467f-97ab-5d55289f156d

📥 Commits

Reviewing files that changed from the base of the PR and between 99285d4 and e326194.

📒 Files selected for processing (3)
  • .github/workflows/api-container-build-push.yml
  • .github/workflows/mcp-container-build-push.yml
  • .github/workflows/ui-container-build-push.yml
💤 Files with no reviewable changes (3)
  • .github/workflows/ui-container-build-push.yml
  • .github/workflows/api-container-build-push.yml
  • .github/workflows/mcp-container-build-push.yml

📝 Walkthrough

Walkthrough

The trigger-deployment job is removed from all three container build-push workflows (api, mcp, ui). Each removed job previously used peter-evans/repository-dispatch to send a deployment event with the commit SHA and short SHA to a downstream dispatch repository after a successful push build.

Changes

Remove deployment dispatch from container build workflows

Layer / File(s) Summary
Remove trigger-deployment job from all three workflows
.github/workflows/api-container-build-push.yml, .github/workflows/mcp-container-build-push.yml, .github/workflows/ui-container-build-push.yml
Deletes the trigger-deployment job in each workflow, which conditionally fired on push events after a successful build and invoked peter-evans/repository-dispatch to emit api-prowler-deployment, mcp-prowler-deployment, and UI deployment events with sha/short_sha payloads to the CLOUD_DISPATCH repository.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and concisely describes the main change: removal of legacy deployment dispatch jobs from three CI workflows.
Description check ✅ Passed The PR description covers Context, Description, and Steps to review sections with clear explanations; most template sections are addressed or noted as N/A for this CI-only change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-legacy-cloud-deployment-dispatch

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant