chore(ci): remove legacy prowler-api/ui/mcp cloud-deployment dispatch jobs#11644
chore(ci): remove legacy prowler-api/ui/mcp cloud-deployment dispatch jobs#11644cesararroba wants to merge 1 commit into
Conversation
|
✅ All necessary |
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughThe ChangesRemove deployment dispatch from container build workflows
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Context
The
trigger-deploymentjobs in the api/ui/mcp container-build-push workflows firedrepository_dispatchevents (api-prowler-deployment,ui-prowler-deployment,mcp-prowler-deployment) to kick off the legacy cloud deployment workflows. Those cloud deployment workflows targeted dev stacks that have since been decommissioned, so these dispatch senders no longer have a receiver.These container-build workflows are synced upstream (prowler → prowler-cloud), so the senders must be removed here too — leaving them in OSS prowler would re-introduce them on the next sync. The companion cloud-side removal is prowler-cloud PR #4691.
Description
Removes the trailing
trigger-deploymentjob from each of the three container-build-push workflows:.github/workflows/api-container-build-push.yml(api-prowler-deployment).github/workflows/mcp-container-build-push.yml(mcp-prowler-deployment).github/workflows/ui-container-build-push.yml(ui-prowler-deployment)Each removed job was a leaf (
needs: [setup, container-build-push]) with nothing depending on it, so noneeds:rewiring was required. All other jobs (setup,notify-release-started,container-build-push,create-manifest,notify-release-completed) are untouched.pr-merged.ymlis intentionally left alone — it dispatchesprowler-pull-request-merged(the PR-sync mechanism), not a deployment.Steps to review
trigger-deploymentjob block is removed in each of the 3 files.grep -rn 'trigger-deployment\|prowler-deployment' .github/workflows/returns no matches.pr-merged.yml'sprowler-pull-request-mergeddispatch is still present.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Summary by CodeRabbit