Skip to content

Replace Global Mutation in UKy Scaling#266

Draft
MarcusHolly wants to merge 4 commits into
prommis:mainfrom
MarcusHolly:replace_global_mutation_scaling
Draft

Replace Global Mutation in UKy Scaling#266
MarcusHolly wants to merge 4 commits into
prommis:mainfrom
MarcusHolly:replace_global_mutation_scaling

Conversation

@MarcusHolly

@MarcusHolly MarcusHolly commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary/Motivation:

Addresses a comment raised by Doug here: #260 (comment)
Status: Waiting on the next IDAES release

Changes proposed in this PR:

  • Replaces the global mutation in the UKy flowsheet scaling routine

Reviewer's checklist / merge requirements:

  • The head branch (i.e. the "source" of the changes) is not the main branch on the PR author's fork
  • Documentation
  • Tests
  • Diagnostic tests for models

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md file
    at the top level of this directory.

  2. I represent I am authorized to make the contributions and grant the license. If my employer has
    rights to intellectual property that includes these contributions, I represent that I have
    received permission to make contributions and grant the required license on behalf of that
    employer.

@MarcusHolly MarcusHolly self-assigned this Jun 10, 2026
@dallan-keylogic

Copy link
Copy Markdown
Contributor

This PR will have to wait until the new IDAES release, because it relies on the new default scaling API contained therein.

@MarcusHolly MarcusHolly marked this pull request as draft June 11, 2026 18:49
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Jun 15, 2026
@ksbeattie

Copy link
Copy Markdown
Contributor

Needs idaes release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants