Skip to content

Fix horizon rings#431

Open
TheSkorm wants to merge 1 commit into
masterfrom
fix-horizon-rings
Open

Fix horizon rings#431
TheSkorm wants to merge 1 commit into
masterfrom
fix-horizon-rings

Conversation

@TheSkorm

@TheSkorm TheSkorm commented Jun 5, 2026

Copy link
Copy Markdown
Member

Resolves issue Ranse Parker is having with horizon rings

image

@ke5gdb

ke5gdb commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

I strongly disagree with this approach. Having horizon, subhorizon, and subsubhorizon will only kick the can on the root issue: we'll need more rings later on. The rings should be programmatically defined such that a simple runtime configuration or environment option with a list of ranges and colors.

Please consider such a change.

@jelson

jelson commented Jun 5, 2026

Copy link
Copy Markdown

@ke5gdb I tried a simpler approach (#432) that just adds a toggle switch to the settings menu to turn rings off.

@ke5gdb

ke5gdb commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Ah, but that's not the problem. The problem is that there are a few toxic people that melted down over the horizon rings. Had there not been meltdowns, the setting likely would've been reimplemented and everything would've been fine.

So the proposal is to add rings for each new meltdown.

@jelson

jelson commented Jun 5, 2026

Copy link
Copy Markdown

I agree with you that people's meltdowns over the rings was not a good look. You are a volunteer project, not a customer service org! But, adding more rings out of spite seems equally bad to me. I'm trying to hold the community together with what, objectively, should be a non controversial feature that lets people who don't want rings turn them off.

@xssfox

xssfox commented Jun 5, 2026

Copy link
Copy Markdown

I strongly disagree with this approach. Having horizon, subhorizon, and subsubhorizon will only kick the can on the root issue: we'll need more rings later on. The rings should be programmatically defined such that a simple runtime configuration or environment option with a list of ranges and colors.

Please consider such a change.

Maybe we can ensure that at least 2 are always visible regardless of zoom level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants