Skip to content

Update deny config to ACK current advisories - #403

Open
alerque wants to merge 1 commit into
projectfluent:mainfrom
alerque:ack-advisories
Open

alerque wants to merge 1 commit into
projectfluent:mainfrom
alerque:ack-advisories

Conversation

@alerque

@alerque alerque commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Housekeeping... looking around for what needs attention most urgently.

@alerque
alerque enabled auto-merge (rebase) September 25, 2026 22:09
Comment thread deny.toml Outdated
[advisories]
ignore = [
"RUSTSEC-2025-0056", # unmaintained: adler; should switch to adler2
"RUSTSEC-2026-0007", # vulnerability: adler; irrelevant because we don't use BytesMut

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in bytes, not adler.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Also now irrelevant, this advisory only turned up for me because I was running cargo deny against an old lock file. With a fresh one this advisory is already cleared because bytes is up to date. Since we don't track the Cargo.lock file (even though we probably should) it's irrelevant to ACK an already past advisory.

Comment thread deny.toml Outdated
[bans]
multiple-versions = "deny"
skip = [
{ name = "rustc-hash" },

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: Could this include the version?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could, but I don't think that would help. We would have to list it twice, once for each of the 1.x and 2.x versions that are required as transitive dependencies that require them. Then they would have to be updated any time minor versions of those came out and got bumped. I'd rather just let them update to minor & patch releases in the right series as long as the anything still depends on the 1.x releases.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also subject to my ancient lock file. We no longer need two rustc-hash major versions. But now the same story is true for syn which we transitively depend on both 2.x and 3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants