Skip to content

support polling in cvu tests#2043

Merged
dczulada merged 8 commits into
masterfrom
cvu_turbo_stream
Jun 2, 2026
Merged

support polling in cvu tests#2043
dczulada merged 8 commits into
masterfrom
cvu_turbo_stream

Conversation

@dczulada

Copy link
Copy Markdown
Contributor

Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.93%. Comparing base (9874404) to head (246f3a5).

Files with missing lines Patch % Lines
app/controllers/test_executions_controller.rb 87.87% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2043      +/-   ##
==========================================
- Coverage   91.98%   91.93%   -0.05%     
==========================================
  Files         159      159              
  Lines        7311     7328      +17     
==========================================
+ Hits         6725     6737      +12     
- Misses        586      591       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dczulada dczulada marked this pull request as ready for review May 1, 2026 19:39
@dczulada dczulada requested a review from elsaperelli May 19, 2026 12:40
@dczulada dczulada force-pushed the cvu_turbo_stream branch 2 times, most recently from c10250a to 8172a5e Compare May 21, 2026 13:10
@dczulada dczulada force-pushed the cvu_turbo_stream branch from 8172a5e to c5af919 Compare May 29, 2026 14:47

@elsaperelli elsaperelli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments but the functionality is looking great!

Comment thread app/views/products/_filtering_test_link.html.erb Outdated
Comment thread app/views/products/_filtering_test_link.html.erb Outdated
Comment thread app/views/products/show.turbo_stream.erb Outdated
Comment thread app/views/products/show.turbo_stream.erb Outdated
Comment thread app/views/program_tests/show.turbo_stream.erb Outdated
Comment thread app/views/program_tests/show.turbo_stream.erb Outdated

@elsaperelli elsaperelli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@dczulada dczulada merged commit 2be10dd into master Jun 2, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants