Skip to content

2026au#2039

Merged
dczulada merged 12 commits into
masterfrom
2026au
Jun 12, 2026
Merged

2026au#2039
dczulada merged 12 commits into
masterfrom
2026au

Conversation

@dczulada

Copy link
Copy Markdown
Contributor

Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@codecov

codecov Bot commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.94%. Comparing base (779c071) to head (fc1ca22).

Files with missing lines Patch % Lines
app/models/cms_program_task.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2039   +/-   ##
=======================================
  Coverage   91.94%   91.94%           
=======================================
  Files         159      159           
  Lines        7334     7337    +3     
=======================================
+ Hits         6743     6746    +3     
  Misses        591      591           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dczulada dczulada requested a review from elsaperelli June 11, 2026 16:26
@dczulada dczulada marked this pull request as ready for review June 11, 2026 16:27

@elsaperelli elsaperelli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment so far- but looking good!

Comment thread lib/cypress/api_measure_evaluator.rb

@elsaperelli elsaperelli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@dczulada dczulada merged commit a0177f2 into master Jun 12, 2026
12 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants