feat(backend/nest): implement frame module#786
Open
stijnvdkolk wants to merge 1 commit into
Open
Conversation
stijnvdkolk
force-pushed
the
feature/nest/notice-module
branch
from
ae68597 to
2cae868
Compare
stijnvdkolk
force-pushed
the
feature/nest/frame-module
branch
from
e16c9f6 to
c1a5a96
Compare
Rocked03
reviewed
Jun 16, 2026
Comment on lines
+31
to
+35
| const user: DiscordUserProfile = { | ||
| id: "1", | ||
| username: "test_user_1", | ||
| profilePictureUrl: "https://example.com/avatar1.png", | ||
| }; |
Member
There was a problem hiding this comment.
we have these constants in multiple places, would it be appropriate to have a shared helpers class or something?
Rocked03
reviewed
Jun 16, 2026
| }; | ||
|
|
||
| /** Orders bounds so (x0, y0) is the top-left and (x1, y1) the bottom-right. */ | ||
| const normalizeFrameBounds = <T extends z.infer<typeof FrameBoundsModel>>( |
Member
There was a problem hiding this comment.
these are also used for stuff like history, would it be better to have a more generic name?
Rocked03
approved these changes
Jun 16, 2026
Rocked03
left a comment
Rocked03
left a comment
Member
There was a problem hiding this comment.
a few thoughts but looks fine to me
stijnvdkolk
force-pushed
the
feature/nest/notice-module
branch
from
2cae868 to
a2a8e34
Compare
stijnvdkolk
force-pushed
the
feature/nest/frame-module
branch
from
c1a5a96 to
2c1531d
Compare
stijnvdkolk
force-pushed
the
feature/nest/notice-module
branch
from
a2a8e34 to
312962c
Compare
stijnvdkolk
force-pushed
the
feature/nest/frame-module
branch
from
2c1531d to
33f0a80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.