Skip to content

Flat Lighting Compatibility patch - #25

Merged
programmer1o1 merged 2 commits into
programmer1o1:masterfrom
AshenSolYT:flat-lighting-compat
Nov 18, 2026
Merged

programmer1o1 merged 2 commits into
programmer1o1:masterfrom
AshenSolYT:flat-lighting-compat

Conversation

@AshenSolYT

@AshenSolYT AshenSolYT commented Nov 15, 2026 •

Copy link
Copy Markdown

Skip directional shading on merged quads when the Flat Lighting mod is installed and when cardinal lighting is off. It only reads only its config file (flat-lighting.json); no Flat Lighting code is ever used. The lighting behavior is unchanged when the mod isn't installed or cardinal lighting is on.

and this is the bug if cardinal lighting is off

image

ignore the weird terrain it's a custom lod mod

Skip directional shading on merged quads when the Flat Lighting mod is installed and when cardinal lighting is off. It only reads only its config file (flat-lighting.json); no Flat Lighting code is ever used. The lighting behavior is unchanged when the mod isn't installed or cardinal lighting is on.
@AshenSolYT

Copy link
Copy Markdown
Author

@programmer1o1 this is a pretty small patch that fixes a bug with flat lighting

@AshenSolYT

Copy link
Copy Markdown
Author

and yes it does work
it is from a top down and with merging set to always again ignore the other stuff it's a fork of a lod mod im working on
image

@programmer1o1

Copy link
Copy Markdown
Owner

thanks for the pull request! the mixin changes look good, but isFlatLighting() reads and parses the json on every chunk build, which is probably gonna hurt performance with the mod installed. can you cache it (refresh on file change or every second or so)? also check what flat lighting's default is if the file is missing. thanks again!

@AshenSolYT

AshenSolYT commented Nov 18, 2026 •

Copy link
Copy Markdown
Author

@programmer1o1 should i reopen the pull request?
edit nvm

@AshenSolYT
AshenSolYT marked this pull request as draft November 18, 2026 19:43
@AshenSolYT
AshenSolYT marked this pull request as ready for review November 18, 2026 19:46
@AshenSolYT

Copy link
Copy Markdown
Author

okay you can check the latest commit

@programmer1o1
programmer1o1 merged commit a61658d into programmer1o1:master Nov 18, 2026
1 check passed
@programmer1o1

Copy link
Copy Markdown
Owner

merged, thanks for the pull request and for fixing the caching so fast! will be in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants