fix(security): WS rate-limit XFF bypass + auth gate on public-keys/all#115
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two security issues raised in the testers thread.
1. WebSocket rate-limit bypass (MEDIUM) —
server.jsgetClientIp()used the leftmostX-Forwarded-Forvalue, which is client-controlled. An attacker can send a new fakeX-Forwarded-Forper connection to get a fresh "IP" each time and completely bypass the per-IP WebSocket connection limit (WS_MAX_CONNECTIONS_PER_IP).Fix mirrors the existing trusted-proxy logic in
src/lib/server/rate-limiter.js:TRUSTED_PROXY_COUNT > 0, read the Nth-from-right XFF entry (only hops appended by infra you control are trustworthy);X-Real-IPthen the raw socket peer address — never the spoofable leftmost XFF.2. Unauthenticated user enumeration —
GET /api/crypto/public-keys/allThe endpoint used the service-role key (bypasses RLS) and had no auth check, so any anonymous request returned every
user_id+ public key — full user-base enumeration.Fix adds the same cookie/JWT
authenticateUsergate already used by the siblingGET /api/crypto/public-keysand returns401when unauthenticated. The only legitimate caller (src/lib/crypto/key-sync-service.js) is an authenticated client, so no functional change for real users. Public keys remain non-secret; the membership list no longer leaks.Both changes are minimal, follow existing repo patterns, and pass
node --check.