Repository navigation
fix(assistant): reuse a repeated read in one turn - #250
Merged
Merged
Conversation
A model can ask for the same read two times in one turn, for example the same time report with the same range. The server ran both calls, and the trace showed two identical rows. Keep the result of each read for the turn, by tool name and arguments. A repeat gets that result and sends no trace events. Each call still gets its own tool row, so the model has an answer for every call. A write clears the kept results, and a failed read is not kept.
get_timer returns the elapsed time, which moves with the clock, so a repeat in the same turn must run again. The .then that forgets a failed read also needs a rejection handler, or a rejected read becomes an unhandled rejection. Add a test that a write between two equal reads runs the second read again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A model can ask for the same read two times in one turn, for example the same time report with the same range. The server ran both calls, and the trace showed two identical rows.
Change
runOrReuseinassistant.service.ts).tool_startortool_resultevent, so the web and mobile traces show one row.Test
assistant.test.ts: the same read twice in a batch and once in the next step gives one trace step and three equal tool rows.bun test(assistant),tsc,bun run checkandbun run complexitypass.