Conversation
ulgens
marked this pull request as ready for review
September 12, 2026 23:08
Contributor
There was a problem hiding this comment.
Hi @ulgens! Thanks for the pr. Hashes check out and the new workflow is clean under zizmor.
The Git Hooks job hasn't run here yet. Could you run the hooks on this branch once? I ran prek run --all-files and got exit 14 with 58 findings locally, mostly in the release workflows, and want to confirm that matches before we decide how to sequence this.
ulgens
marked this pull request as draft
September 21, 2026 14:05
Relates to: - processing#8620 - processing#9033
Contributor
Author
|
@Vaivaswat2244 You are right and I'm not sure how I forgot that. I'll incrementally update the PR to handle them. |
https://docs.zizmor.sh/audits/#secrets-outside-env I'm not exactly sure about benefits of this rule and fixing the violations require changes in repo settings. Disabling for now, can be revisited later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to:
Depends on:
Changes:
Add zizmor to git hooks and CI
PR Checklist
npm run lintpasses