feat(runes): rewrite SliceSimulator and test component to runes#44
feat(runes): rewrite SliceSimulator and test component to runes#44ivenuss wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e71dd15. Configure here.
| </article> | ||
| {:else if slices.length} | ||
| <!-- svelte-ignore a11y-no-static-element-interactions --> | ||
| <!-- svelte-ignore a11y_no_static_element_interactions, event_directive_deprecated --> |
There was a problem hiding this comment.
Unnecessary event_directive_deprecated svelte-ignore for new syntax
Low Severity
The event_directive_deprecated svelte-ignore directive was newly added in this PR, but it's unnecessary. This warning only fires when using the old on:click syntax — the code already uses the new onclick/onsubmit/onkeypress attributes (lines 72–74), so the warning will never trigger. The stale ignore directive is misleading and suggests the old syntax is still in use.
Reviewed by Cursor Bugbot for commit e71dd15. Configure here.
|
And the reason why I noticed this is that we cannot use |


Changes
Rewrites
SliceSimulator&PrismicLinkTestWrapperto Svelte 5 runes.Fixes
Fixes #40 which introduced Svelte 4 syntax which shoudnl't occur in the new codebase as #32 has been already merged.
Since
<slot />has been deprecated and it is recommended to use snippets instead.So this will no longer work:
And you should do:
Codesmith can help with this PR — just tag
@codesmithor enable autofix.Note
Medium Risk
Introduces a breaking API change in
SliceSimulator(slot → required snippet) that can break consumers at compile-time; runtime logic changes are otherwise localized to UI/event wiring.Overview
Updates
SliceSimulatorandPrismicLinkTestWrapperto Svelte 5 runes by switching to$props()/$state()and modern event bindings (onclick/onsubmit/onkeypress) and class handling.SliceSimulatornow renders content via a requiredchildrensnippet ({@render ...}) instead of<slot {slices} />, changing the public usage fromlet:slicesslot props to snippet-based rendering.Reviewed by Cursor Bugbot for commit e71dd15. Bugbot is set up for automated code reviews on this repo. Configure here.