Skip to content

Add flag octicon#1203

Draft
ericwbailey wants to merge 5 commits into
mainfrom
add-flag-octicon
Draft

Add flag octicon#1203
ericwbailey wants to merge 5 commits into
mainfrom
add-flag-octicon

Conversation

@ericwbailey
Copy link
Copy Markdown

@ericwbailey ericwbailey commented May 11, 2026

This PR adds flag-16 and flag-24 icons to Octicons, following this request.

The current working draft is contained in this Figma branch, which will be merged when this PR is merged.

@ericwbailey ericwbailey requested a review from a team as a code owner May 11, 2026 20:17
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 11, 2026

🦋 Changeset detected

Latest commit: 2431e02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new flag Octicon (16px and 24px variants) and registers its search keywords, addressing the request in primer/issues/6624.

Changes:

  • Add new SVG assets: icons/flag-16.svg and icons/flag-24.svg
  • Add flag entry to keywords.json
  • Add a changeset to release the new icon in the next minor version
Show a summary per file
File Description
keywords.json Adds keyword aliases for the new flag icon name.
icons/flag-16.svg Introduces the 16px flag SVG asset.
icons/flag-24.svg Introduces the 24px flag SVG asset.
.changeset/spotty-bats-call.md Declares a minor release for the new icon addition.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/4 changed files
  • Comments generated: 0

@dylanatsmith
Copy link
Copy Markdown
Member

Hey Eric. I have some concerns about the design here for consistency with the icon set.

This doesn’t appear to follow the design guidelines for stroke width, etc. and I think we should use an outlined flag to match icons such as comment, law, pin, etc.

@ericwbailey
Copy link
Copy Markdown
Author

@dylanatsmith I can revisit, no problem. Will tag you when the design is updated and pushed up.

@ericwbailey ericwbailey marked this pull request as draft May 12, 2026 16:24
Copy link
Copy Markdown
Contributor

@llastflowers llastflowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls re-request review when @dylanatsmith requested changes are done! Just doing this so I'll get a new review notification at that time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants