Add flag octicon#1203
Conversation
🦋 Changeset detectedLatest commit: 2431e02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR adds a new flag Octicon (16px and 24px variants) and registers its search keywords, addressing the request in primer/issues/6624.
Changes:
- Add new SVG assets:
icons/flag-16.svgandicons/flag-24.svg - Add
flagentry tokeywords.json - Add a changeset to release the new icon in the next minor version
Show a summary per file
| File | Description |
|---|---|
keywords.json |
Adds keyword aliases for the new flag icon name. |
icons/flag-16.svg |
Introduces the 16px flag SVG asset. |
icons/flag-24.svg |
Introduces the 24px flag SVG asset. |
.changeset/spotty-bats-call.md |
Declares a minor release for the new icon addition. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/4 changed files
- Comments generated: 0
|
Hey Eric. I have some concerns about the design here for consistency with the icon set. This doesn’t appear to follow the design guidelines for stroke width, etc. and I think we should use an outlined flag to match icons such as |
|
@dylanatsmith I can revisit, no problem. Will tag you when the design is updated and pushed up. |
llastflowers
left a comment
There was a problem hiding this comment.
pls re-request review when @dylanatsmith requested changes are done! Just doing this so I'll get a new review notification at that time 👍
This PR adds
flag-16andflag-24icons to Octicons, following this request.The current working draft is contained in this Figma branch, which will be merged when this PR is merged.