Updates eslint + prettier and fixes warnings by davidpfarrell · Pull Request #77 · primefaces/sakai-vue

davidpfarrell · 2025-09-07T19:56:58Z

Updates packages:

eslint : ^8.57.0 => ^9.35.0
prettier : ^3.2.5 => 3.6.2 (pinned)
@vue/eslint-config-prettier : ^9.0.0 => ^10.2.0

Note: Uses '--save-exact' for prettier as per best practices

Removes packages:

@rushstack/eslint-patch
eslint-plugin-vue

Adds packages:

@vue/eslint-config-standard
eslint-config-flat-gitignore
eslint-config-prettier
eslint-plugin-prettier
eslint-plugin-tailwindcss
eslint-plugin-vue

Regenerates package-lock.json:

'npm cache clean --force'
'rm -rf node_modules'
'rm package-lock.json'
'npm install'

Migrates '.eslintrc.js' to 'eslint.config.mjs':

Exposes 'globals.browser' (leaves 'globals.node' commented)
Adds '.vscode' folder to GlobalIgnore rules
Adds GitIgnore rules
Adds TailwindCSS rules
Adds custom rules to align with project norms

Addresses all remaining eslint and prettier warnings:

.prettierrc.json
CHANGELOG.md
index.html
jsconfig.json
vercel.json
src/assets/layout/_preloading.scss
src/views/pages/Crud.vue
src/views/pages/Landing.vue
src/views/uikit/TableDoc.vue

Adds/Updates 'package.json' scripts:

Removes deprecated '--ignore-path' from 'lint' script
Removes '--fix' from 'lint' script, leaving as a 'check' action
Adds 'lint-fix' script as a 'fix' action
Adds 'prettier' script as a 'check' action
Adds 'prettier-fix' script as a 'fix' action

New script details:

lint : 'eslint . --ext .vue,.js,.jsx,.cjs,.mjs'
lint-fix : 'eslint . --ext .vue,.js,.jsx,.cjs,.mjs --fix'
prettier : 'prettier --check .'
prettier-fix : 'prettier --write .'

Adds entries to '.gitignore':

'dist-ssr'
'components.d.ts'

Adds '.prettierignore' file:

'.vscode/'
'public/demo/data/'
'src/assets/demo/flags/flags.css'

Removes 'lang="ts"' from Landing.vue

Updates packages: - eslint : ^8.57.0 => ^9.35.0 - prettier : ^3.2.5 => 3.6.2 (pinned) - @vue/eslint-config-prettier : ^9.0.0 => ^10.2.0 Note: Uses '--save-exact' for prettier as per best practices Removes packages: - @rushstack/eslint-patch - eslint-plugin-vue Adds packages: - @vue/eslint-config-standard - eslint-config-flat-gitignore - eslint-config-prettier - eslint-plugin-prettier - eslint-plugin-tailwindcss - eslint-plugin-vue Regenerates package-lock.json: - 'npm cache clean --force' - 'rm -rf node_modules' - 'rm package-lock.json' - 'npm install' Migrates '.eslintrc.js' to 'eslint.config.mjs': - Exposes 'globals.browser' (leaves 'globals.node' commented) - Adds '.vscode' folder to GlobalIgnore rules - Adds GitIgnore rules - Adds TailwindCSS rules - Adds custom rules to align with project norms Addresses all remaining eslint and prettier warnings: - .prettierrc.json - CHANGELOG.md - index.html - jsconfig.json - vercel.json - src/assets/layout/\_preloading.scss - src/views/pages/Crud.vue - src/views/pages/Landing.vue - src/views/uikit/TableDoc.vue Adds/Updates 'package.json' scripts: - Removes deprecated '--ignore-path' from 'lint' script - Removes '--fix' from 'lint' script, leaving as a 'check' action - Adds 'lint-fix' script as a 'fix' action - Adds 'prettier' script as a 'check' action - Adds 'prettier-fix' script as a 'fix' action New script details: - lint : 'eslint . --ext .vue,.js,.jsx,.cjs,.mjs' - lint-fix : 'eslint . --ext .vue,.js,.jsx,.cjs,.mjs --fix' - prettier : 'prettier --check .' - prettier-fix : 'prettier --write .' Adds entries to '.gitignore': - 'dist-ssr' - 'components.d.ts' Adds '.prettierignore' file: - '.vscode/' - 'public/demo/data/' - 'src/assets/demo/flags/flags.css' Removes 'lang="ts"' from Landing.vue

davidpfarrell · 2025-09-07T20:02:42Z

Greetings! I maintain TekWizely/wails-template-primevue-sakai which integrates Sakai Vue as a GoLang Wails Starter Template, making it possible to write desktop apps with Sakai as the UI framework.

In preparing to create a TypeScript conversion of the project, it became beneficial to upgrade to ESLint V9.

I decided to see if I could route those changes back up through this project. That way my project doesn't have to stray away from its roots.

Thanks in for creating/sharing Sakai Vue and please let me know if you have any questions about my PR.

-DF

ps:

Hiding Whitespace will make the changes easier to review.

The largest changes are to eslint.config.mjs and to package.json.

Almost all others are the result of fixing lint/prettier warnings.

All non-whitespace changes were manually applied/reviewed, having prettier fix one a time then comparing to original.

davidpfarrell · 2025-09-07T20:13:50Z

-        "prettier": "^3.2.5",
+        "prettier": "3.6.2",


Version pinned according to official documentation.

davidpfarrell · 2025-09-07T20:32:01Z

 .env
 dist
+dist-ssr
+components.d.ts


The official stance on whether to add components.d.ts to source control is mixed, with pros and cons on both sides, but since this project did not already have it, I erred on the don't-add-it side.

davidpfarrell · 2025-09-07T20:35:14Z

@@ -1,17 +1,15 @@
-<!DOCTYPE html>
+<!doctype html>


Prettier changed this to doctype and since the value is case-insensitive and there is no community consensus on UPPER vs lower, I left it.

#DontTauntHappyFunBall

davidpfarrell · 2025-09-07T20:37:17Z

@@ -1,4 +1,4 @@
-<script setup lang="ts">
+<script setup>


This looked like a bug so I removed it ?

davidpfarrell · 2025-09-07T20:38:17Z

-    expandedRows.value = products.value.reduce((acc, p) => (acc[p.id] = true) && acc, {});
+    expandedRows.value = products.value.reduce((acc, p) => {
+        acc[p.id] = true;
+        return acc;
+    }, {});


ESLint was NOT impressed by this clever one-liner - I manually coded the fix.

davidpfarrell · 2025-09-07T20:40:01Z

-                            <InputText v-model="filters['global'].value" placeholder="Search..." />
+                            <InputText v-model="filters.global.value" placeholder="Search..." />


I changed this vs leaving the warning or disabling the warning, but happy to revert it and disable the warning as a 'project norm' override if you like?

davidpfarrell · 2025-09-07T20:40:11Z

-                        <InputText v-model="filters1['global'].value" placeholder="Keyword Search" />
+                        <InputText v-model="filters1.global.value" placeholder="Keyword Search" />


I changed this vs leaving the warning or disabling the warning, but happy to revert it and disable the warning as a 'project norm' override if you like?

davidpfarrell · 2025-09-07T20:42:32Z

 **Implemented New Features and Enhancements**

-   Update PrimeVue version
+- Update PrimeVue version


As this file was small, and the fixes were only whitespace, I let prettier fix the file, but I'm happy to revert this and add it to the .prettierignore if you like?

Already covered in .gitignore, which prettier will inspect for ignore patterns.

davidpfarrell · 2025-09-07T20:57:15Z

+.vscode/
+public/demo/data/
+src/assets/demo/flags/flags.css


Just confirmed via prettier docs on ignoring that it picks up .gitignore when present, so we only need to add files here that are in the repository (since they likely won't be in .gitignore).

davidpfarrell · 2025-10-06T01:53:08Z

@tugcekucukoglu , @cagataycivici , @bahadirsofuoglu , @sezisfurkan :

Any chance of getting some eyes on this?

davidpfarrell commented Sep 7, 2025

View reviewed changes

Comment thread .prettierignore

Removes '.idea' from .prettierignore

4423956

Already covered in .gitignore, which prettier will inspect for ignore patterns.

davidpfarrell commented Sep 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates eslint + prettier and fixes warnings#77

Updates eslint + prettier and fixes warnings#77
davidpfarrell wants to merge 2 commits into
primefaces:masterfrom
davidpfarrell:chore/update-eslint-prettier-fix-warnings

davidpfarrell commented Sep 7, 2025

Uh oh!

davidpfarrell commented Sep 7, 2025 •

edited

Loading

Uh oh!

davidpfarrell Sep 7, 2025

Uh oh!

davidpfarrell Sep 7, 2025

Uh oh!

davidpfarrell Sep 7, 2025

Uh oh!

davidpfarrell Sep 7, 2025

Uh oh!

davidpfarrell Sep 7, 2025

Uh oh!

davidpfarrell Sep 7, 2025

Uh oh!

davidpfarrell Sep 7, 2025

Uh oh!

davidpfarrell Sep 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

davidpfarrell Sep 7, 2025

Uh oh!

davidpfarrell commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		<InputText v-model="filters['global'].value" placeholder="Search..." />
		<InputText v-model="filters.global.value" placeholder="Search..." />

		<InputText v-model="filters1['global'].value" placeholder="Keyword Search" />
		<InputText v-model="filters1.global.value" placeholder="Keyword Search" />

Conversation

davidpfarrell commented Sep 7, 2025

Uh oh!

davidpfarrell commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidpfarrell Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidpfarrell commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

davidpfarrell commented Sep 7, 2025 •

edited

Loading

davidpfarrell Sep 7, 2025 •

edited

Loading