This repository was archived by the owner on Jun 28, 2026. It is now read-only.
fix(datepicker): hour decrement loops incorrectly when minDate hour i…#19561
Open
nenaki wants to merge 1 commit into
Open
fix(datepicker): hour decrement loops incorrectly when minDate hour i…#19561nenaki wants to merge 1 commit into
nenaki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect behaviour in the
constrainTimemethod where clickingthe hour decrement button causes the hour to loop incorrectly
(e.g. 9 → 11 → 10 → 9) when a
minDatewith a specific hour is set.Root Cause
A
switch(true)case inconstrainTimewas incorrectly settingreturnTimeTriple[0] = 11and flippingthis.pm = truewheneverthe decremented hour was exactly one below the
minDatehour.This case was redundant as AM/PM toggling is already handled
by
toggleAMPMIfNotMinDatebeforeconstrainTimeis called.Fix
Removed the redundant and incorrect case from the
switch(true)block in
constrainTime.Fixes #19557