Repository navigation
Fix annoying warning about -fvisibility-inlines-hidden being passed to C files with GCC. - #2808
Merged
Merged
Conversation
… to C files with GCC.
ActuallyaDeviloper
force-pushed
the
master
branch
from
September 25, 2026 19:57
63417c8 to
f563b14
Compare
nickclark2016
approved these changes
Sep 25, 2026
nickclark2016
left a comment
Member
There was a problem hiding this comment.
LGTM. Appreciate the AI disclosure :)
Jarod42
approved these changes
Sep 25, 2026
samsinsane
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling with GCC (not Clang) in Make or Ninja, I noticed the following annoying warning spam:
Apparently this flag is only for C++. (Source: https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html, where this option is listed at "command-line options that are only meaningful for C++ programs".)
The solution: Only pass this flag to the C++ compiler.
To reproduce:
Details
Reproduce by creating a
premake5.luacompiling a
main.cand compile with
premake5 gmake && cd build/gmake && makeor the equivalent ninja backend.AI disclosure: The fix was suggested by Claude Opus 5.5. I reviewed the code and created this pull request.