Fix Mobkoi adapter to support aliased requests#4840
Open
gabrielmougard wants to merge 2 commits into
Open
Conversation
The adapter set TypedBid.Seat="mobkoi" on every bid. That field is what
Prebid Server's bidder-code-spoofing guard inspects, so when the adapter is
invoked under an alias (e.g. mobkoi_s2s_alias) the seat ("mobkoi") no longer
matches the requested code and PBS rejects the bid. Mobkoi was one of only ~4
adapters that override the seat at all.
Leave Seat empty so PBS labels the bid with the requested bidder code, which
makes aliases work for every publisher without any publisher-side change.
Update JSON exemplars to expect an empty seat and add a regression test.
Code coverage summaryNote:
mobkoiRefer here for heat map coverage report |
Code coverage summaryNote:
mobkoiRefer here for heat map coverage report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adapter set
TypedBid.Seat="mobkoi"on every bid. When the adapter is invoked under an alias (e.g.mobkoi_s2s_alias) the seat ("mobkoi") no longer matches the requested code and PBS rejects the bid.Leave Seat empty so PBS labels the bid with the requested bidder code, which makes aliases work for every publisher without any publisher-side change.
Update JSON exemplars to expect an empty seat and add a regression test.