Repository navigation
fix(deps): pin dormant web ip-address override to 10.7.4 - #254
Conversation
Reserve 0.55.60; RED proves the old pin. Bootstrap manifest and dormant-graph GREEN is not installed parser proof. CI-only lock regeneration remains pending. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Authenticated regeneration run 39980968858 changes no packages. Web restore preserves the lock; actual pin/graph tests pass23 and scanner finds zero affected overrides. Preserve all release holds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Validate hook blocked publication after all Fast gates passed. Prove generation with a process-local nonconnecting URL; preserve the failed receipt and require a fresh normal Validate hook. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Passing required checks at the exact final commit is not yet confirmed, and the handoff retains final human review and a no-merge hold.
No open issues 🎉
2 files not reviewed
api/package-lock.json: Generated fileweb/package-lock.json: Generated file
What changed in this PR
This PR addresses the remaining dependency pin in #248 by updating SCIMServer’s dormant web ip-address override to exactly 10.7.4. It does not install the parser or change application behavior.
Changes:
- Corrects the override and adds regressions for the advisory boundary, exact pin, and absent dependency graph.
- Synchronizes API/web manifests, lockfile version metadata, and documentation to
0.55.60, without changing resolved packages. - Records validation evidence and preserves existing merge, deployment, and performance holds.
| File | Description |
|---|---|
web/package.json |
Pins ip-address to 10.7.4; updates product version. |
web/package-lock.json |
Synchronizes version metadata only. |
Session_starter.md |
Records remediation scope, evidence, and holds. |
README.md |
Updates product version and badge. |
docs/WEB_IP_ADDRESS_SECURITY_REMEDIATION.md |
Documents dormant override scope and validation evidence. |
docs/UI_GUIDE.md |
Synchronizes version headers. |
docs/strategy/NPM_SUPPLY_CHAIN_QUARANTINE_POLICY.md |
Records patch eligibility and regeneration constraints. |
docs/SOVEREIGN_AND_GOV_CLOUD_DEPLOYMENT.md |
Synchronizes version headers. |
docs/SCHEMA_CUSTOMIZATION_GUIDE.md |
Synchronizes product version header. |
docs/SCHEMA_ATTRIBUTE_CUSTOMIZATION_GUIDE.md |
Synchronizes product version header. |
docs/REMOTE_DEBUGGING_AND_DIAGNOSIS.md |
Synchronizes product version header. |
docs/RELEASE_NOTES.md |
Explains the proposed correction and its limits. |
docs/PROD_TO_DEV_MIRRORING_AND_FIXTURES.md |
Synchronizes version headers. |
docs/PATCH_OPERATIONS_COMPLETE_GUIDE.md |
Synchronizes product version header. |
docs/OBSERVABILITY_TRACEABILITY_AND_DIAGNOSTICS.md |
Synchronizes product version header. |
docs/MULTI_ENDPOINT_GUIDE.md |
Synchronizes version headers. |
docs/LOGGING_AND_OBSERVABILITY.md |
Synchronizes product version header. |
docs/INDEX.md |
Links remediation evidence and updates version headers. |
docs/GLOBAL_NAVIGATION_AND_WORKFLOW_CONTEXT.md |
Synchronizes product version header. |
docs/ENDPOINT_PROFILE_ARCHITECTURE.md |
Synchronizes product version header. |
docs/ENDPOINT_LIFECYCLE_AND_USAGE.md |
Synchronizes version headers. |
docs/ENDPOINT_CREATION_WIKI.md |
Synchronizes version headers. |
docs/ENDPOINT_CONFIG_FLAGS_REFERENCE.md |
Synchronizes version headers. |
docs/DOCKER_GUIDE_AND_TEST_REPORT.md |
Synchronizes version headers. |
docs/CUSTOM_EXTENSIONS_RFC_GUIDE.md |
Synchronizes product version header. |
docs/CONTEXT_INSTRUCTIONS.md |
Updates version and remediation handoff context. |
docs/COMPLETE_API_REFERENCE.md |
Synchronizes version headers. |
docs/AZURE_DEPLOYMENT_AND_USAGE_GUIDE.md |
Synchronizes version headers. |
docs/AUTHENTICATION_GUIDE.md |
Synchronizes product version header. |
DEPLOYMENT.md |
Synchronizes product version header. |
CHANGELOG.md |
Records correction, test counts, and release limits. |
api/src/scripts/check-dependency-pins.spec.ts |
Adds advisory, exact-pin, and dependency-absence regressions. |
api/package.json |
Synchronizes API product version. |
api/package-lock.json |
Synchronizes version metadata only. |
Review effort: Balanced
|
Exact-tip closeout at 4312cc1: required validate and build-and-push passed in39985408698; Analyze passed in39985408881. Freshness and regeneration also passed. Hosted review5631220376 has zero inline findings; its CI-pending observation is now resolved by exact-tip evidence. COMMENTED is not human approval. This handoff deliberately stops UNMERGED; no release/deployment/performance hold is waived. Final Validate hook28/28, API6214 units/2514 HTTP tests(42 existing skips), web1655 tests. Final receipts complement the source documentation's pre-publication authoring checkpoint. |
There was a problem hiding this comment.
🟢 Approval recommended
The bounded override correction has targeted regression coverage, consistent metadata and successful exact-tip build and security checks, with no blocking findings.
No open issues 🎉
2 files not reviewed
api/package-lock.json: Generated fileweb/package-lock.json: Generated file
Review effort: Balanced
Review5631220376: exact-tip evidence and phase authorizationThe earlier review explicitly said Needs a closer look, because exact-final The user has explicitly advanced the initial bounded no-merge checkpoint: Exact source and all six final checksHead:
Actual master protections require strict validate/build-and-push/Analyze; Generated lockfiles: independently verified, NOT bot-reviewedBoth hosted reviews correctly skip generated locks. The machine verification
Machine receipts are retained in Please provide a fresh hosted review/clarification against this unchanged |
|
Review closeout before authorized ordinary merge: original5631220376 remains accurately recorded as Needs a closer look. Later exact-source review5631349090 independently says Approval recommended/no blocking findings after exact-tip CI completed; both are COMMENTED, not human approval. Complete lockfile machine-verification and explicit phase authorization are recorded in6369692908. A further hosted review request was sent after that comment; no third review appeared in the bounded five-minute wait, and none is invented. No source or full-suite rerun was made to influence review. The actual code has no separate pending human action; the user explicitly advanced the old no-merge checkpoint, while all deployment/customer/performance holds stay unchanged. All six exact-head checks remain green and there are zero review threads. Proceeding only with non-admin matching-head merge under the user's authorization. |
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
2 open issues
2 files not reviewed
api/package-lock.json: Generated fileweb/package-lock.json: Generated file
Review effort: Lite
|
Publication checkpoint verified. Ordinary merge5bfff2dea1dec6f3e4b99c9a4cc0e6cb8e27388d is the exact source of the single authoritative postmerge matrix39988309661 SUCCESS, automatic CodeQL39988244899 SUCCESS, and sanctioned pin review39988244921 SUCCESS(API26/Web8 pins, zero records). Publication39989347764 SUCCESS guarded expectedSha before login; version0.55.60 and source-sha tags resolve to immutable index sha256:316a645f021b5c9b833c295d94248e7df00ee37aa13d6d5614e55f9f04c83a4b. Registry BuildKit provenance identifies that run and exact merge in all four inspected source fields. Downloaded build artifact12516682880 digestsha256:12283bfb010d43162815cf53f1a4f3d560dc2333c336c5028ea5f768261a863d matches GitHub. Offline read-only/network-none/zero-mount Node metadata inventory exits0, reads247 package metadata files: product0.55.60, zero ip-address, Hono4.13.11; helper removed. Dormant web10.7.4 override remains NOT an installed parser. Latest tag not promoted. Late review5631619263 arrived after merge/publication, with full-agentic startup timeout plus two fallback suggestions; both answered with actual CommonJS and marker-versus-dated-claim contracts in4362057654/4362057848; threads resolved with complete pagination. Neither late review nor original5631220376 is relabeled approval. Actual later premerge5631349090 was Approval recommended/COMMENTED, not human approval. Complete private receipts: test-results/ip-address-security-20261023/publication-closeout.md. No source changes or duplicate matrix followed feedback. No deployment, performance retry, PR251 merge or release waiver; all genuine customer/visual/capacity/cleanup holds remain. |

Summary
Correct the dormant web ip-address override to exact 10.7.4 for the remaining
pin findings in #248, with synchronized 0.55.60 metadata and CI-only locks.
This PR must remain unmerged under this handoff.
Linked Defect / Plan Reference
docs/WEB_IP_ADDRESS_SECURITY_REMEDIATION.mdTDD Process
api/src/security/)RED: expected 10.7.4, received 10.7.1; 22 passed, one failed.
Final focused GREEN after CI-lock import and web restore: 23/23.
The actual web lock has no ip-address occurrence or incoming dependency edge,
and the installed tree has no parser. This is NOT a patched-parser install
or evidence of exploitable browser shipment. Adding a parser to claim such
proof would be an unrelated dependency change.
Feature / Bug-Fix Commit Checklist (standing rule)
Every behavioral change must include all that apply. Tick or strike through with N/A + reason.
api/test/e2e/exercising the feature through HTTP. N/A new cases: dependency-only change; existing HTTP regression suite runs in the ordinary hook and CI.scripts/live-test.ps1runnable against local + Docker + Azure. N/A: no live mutation authorized and no API behavior changes.docs/with architecture, RFC references, Mermaid diagrams, test coverage.docs/WEB_IP_ADDRESS_SECURITY_REMEDIATION.md; existing build boundary is explained without speculative new diagrams or protocol claims.docs/INDEX.md[Unreleased]entry with full test counts and feature summarySession_starter.mdanddocs/CONTEXT_INSTRUCTIONS.mdapi/package.json(and any other version refs) when behavior changed. Both product manifests and CI-generated locks reserve 0.55.60.No new UI behavior: no invented UI or Playwright feature is included.
Existing PR #251 performance, customer-data, capacity, cleanup403 and
target-specific operator visual verification holds remain unchanged.
No merge, deployment, performance retry, threshold/quota change or waiver.
Validation Output
npm test -- --runInBand --runTestsByPath src/scripts/check-dependency-pins.spec.ts: RED before manifest edit; final PASS 23/23.npm ci --no-audit --no-fund: PASS; lock SHA-256 unchanged, parser remains absent.npm run check:pins: PASS, API26/web8 pins, zero findings/unchecked.npm audit --json: exit1, three existing Moderate affected Vitest packages, zero High/Critical; no ip-address finding. Separate from this bounded change.npm run docs:freshness:fix,npm run docs:content,git diff --check: PASS.DATABASE_URL=postgresql://localhost:1/scim_codegen,PREPUSH_MODE=Validate,git push: PASS, 28/28. Includes API build/lint, web TypeScript/productionbuild, real Mermaid rendering, unit/HTTP/web tests, Prisma generation
and migration linter. First Validate attempt failed only for missing
DATABASE_URL after all 25 Fast gates passed; retained, not erased.
regen-lockfile.ymlrun 39980968858: PASS at sourced6e95717591aed8c8b3a09f1e429ebe44b51f7fb.sha256:714cc0d18f35dcb1c61e600b17843f5765d79b721532681c782c17f7da093b15authenticated against GitHub. Every non-root package unchanged; both locks only synchronize product version metadata. Public URLs/sha512 and empty changed-package age report verified.Standing Rules Acknowledgment
U+2014) anywhere in the diff. Verified viaSelect-String -Pattern ([char]0x2014).git commit --amendon history that has been pushed.api/src/security/forbidden-source-patterns.spec.tswill catch known anti-patterns.api/src/scripts/lint-migrations.tsenforces this. No migration changes.Destructive Migration Override (skip if not applicable)
ALLOW_DESTRUCTIVE_MIGRATION=1in the CI environment for this PRReviewer Hint
Diff areas worth special attention from the reviewer:
synchronize the version only. No CI/workflow/application implementation changes.
describe one distinct flaw, not two independent blockers.
Design disposition accepted: no runtime abstraction needed.
build-and-push and Analyze checks must be green at the exact final tip.