CMake: Disable BUILD_TESTING for toml-f when WITH_TEST=OFF#2
Open
Growl1234 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package
toml-fuse a more general option name,BUILD_TESTING, rather thanWITH_TESTS. Therefore,WITH_TESTS=OFFflag won't be passed totoml-f, andtoml-fwill keep building unittests, which requirestest-drivewhose finding logic is disabled throughWITH_TESTS=OFFset by crest. This is the reason why with flagWITH_TESTS=OFFCMake still downloadstest-driveeven if it exists insubprojects/directory, and this PR is a simple workflow to fix the issue.