Skip to content

fix(cors): mirror Origin header when credentials are allowed (#679) #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackthepunished wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cors): mirror Origin header when credentials are allowed (#679) #696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions pkg/httputil/middleware.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,24 @@ func Logger(logger *slog.Logger) gin.HandlerFunc {
}

// CORS enables permissive CORS headers for development.
//
// Browsers reject responses that combine `Access-Control-Allow-Origin: *`
// with `Access-Control-Allow-Credentials: true`. When the request supplies
// an `Origin` header we mirror it back (with `Vary: Origin`) and allow
// credentials; otherwise we fall back to the wildcard with no credentials.
func CORS() gin.HandlerFunc {
Comment on lines 74 to 80
return func(c *gin.Context) {
c.Header("Access-Control-Allow-Origin", "*") // For development, allow all. Could restrict to localhost:3000
origin := c.GetHeader("Origin")
if origin != "" {
c.Header("Access-Control-Allow-Origin", origin)
c.Header("Vary", "Origin")
c.Header("Access-Control-Allow-Credentials", "true")
} else {
c.Header("Access-Control-Allow-Origin", "*")
}
Comment on lines +82 to +89
c.Header("Access-Control-Allow-Methods", "POST, GET, OPTIONS, PUT, DELETE, PATCH")
c.Header("Access-Control-Allow-Headers", "Accept, Content-Type, Content-Length, Accept-Encoding, X-CSRF-Token, Authorization, x-api-key")
c.Header("Access-Control-Expose-Headers", "Content-Length")
c.Header("Access-Control-Allow-Credentials", "true")

if c.Request.Method == "OPTIONS" {
c.AbortWithStatus(204)
Expand Down
Loading