feat(core): page between jobs from the detail view#43
Open
omar-zeineddine wants to merge 1 commit into
Open
Conversation
|
@omar-zeineddine is attempting to deploy a commit to the Pontus Abrahamsson's projects Team on Vercel. A member of the Team first needs to authorize it. |
380f2a5 to
3e18f25
Compare
Previously the only way to move between jobs was back to the queue list and into the next one. Add prev/next navigation to the job detail page so you can step through a queue in place: - Chevron buttons (left of the title) plus arrow-key shortcuts (left/right), ignored while typing in inputs. - Paging follows the same list, status filter, and sort the queue page was showing — the queue's status/sort ride along in the URL (added to jobSearchSchema), so prev/next on a Failed-filtered view stays within failed jobs. Deep links / command palette / Runs fall back to the full queue list for that queue. - Reuses the shared useJobs query (same cache key as the list) so navigation is instant, and auto-fetches the next page when you reach the last loaded job so next doesn't dead-end. Buttons disable at the ends of the list.
3e18f25 to
1b7f1fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The job detail page had no way to move to an adjacent job — to see the next one you had to go back to the queue list and click into it. Stepping through a run of jobs (e.g. reviewing a batch of failures) meant a lot of back-and-forth.
Fix
Add prev/next navigation to the job detail view:
status/sortnow ride along in the URL (added tojobSearchSchema) and are passed when opening a job, so prev/next on aFailed-filtered, custom-sorted view stays within that view. Deep links, the command palette, and the Runs page (which carry no list context) fall back to the full job list for that queue.useJobsquery — same cache key as the queue list — so navigation is instant when coming from the list, and it auto-fetches the next page when you reach the last loaded job so "next" doesn't dead-end mid-queue.Testing
tsc --noEmit✅biome check✅vite build(UI bundle) ✅