Skip to content

refactor: use strings.Builder to improve performance#1831

Open
stemlaud wants to merge 1 commit into
pokt-network:mainfrom
stemlaud:main
Open

refactor: use strings.Builder to improve performance#1831
stemlaud wants to merge 1 commit into
pokt-network:mainfrom
stemlaud:main

Conversation

@stemlaud

@stemlaud stemlaud commented Oct 11, 2025

Copy link
Copy Markdown

Summary

use strings.Builder to improve performance

Primary Changes:

strings.Builder has fewer memory allocations and better performance.
More info: golang/go#75190

Secondary Changes:

Issue

  • No

Type of change

Select one or more from the following:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Sanity Checklist

  • I have updated the GitHub Issue Metadata: assignees, reviewers, labels, project, iteration and milestone
  • For docs: make docusaurus_start
  • For small changes: make go_develop_and_test and make test_e2e
  • For major changes: devnet-test-e2e label to run E2E tests in CI
  • For migration changes: make test_e2e_oneshot
  • 'TODO's, configurations and other docs

@Olshansk Olshansk self-requested a review October 15, 2025 18:11

@Olshansk Olshansk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stemlaud

  1. Testing - You'll need to run make go_docs and update the docs to make sure this still works.
  2. Merge with main: Please merge with main and resolve conflicts
  3. Description: Please update the PR description
  4. I'll approve the workflows after ☝️

@Olshansk Olshansk added this to Shannon Oct 15, 2025
@github-project-automation github-project-automation Bot moved this to 📋 Backlog in Shannon Oct 15, 2025
@stemlaud stemlaud closed this Oct 29, 2025
@github-project-automation github-project-automation Bot moved this from 📋 Backlog to ✅ Done in Shannon Oct 29, 2025
Signed-off-by: stemlaud <stemlaud@outlook.com>
@stemlaud stemlaud reopened this Oct 29, 2025
@stemlaud

Copy link
Copy Markdown
Author

@stemlaud

  1. Testing - You'll need to run make go_docs and update the docs to make sure this still works.
  2. Merge with main: Please merge with main and resolve conflicts
  3. Description: Please update the PR description
  4. I'll approve the workflows after ☝️

Thanks for your help! @Olshansk

I have followed your suggestions and executed these actions. Please review again. 😄

@cuoguojida

Copy link
Copy Markdown

I made the same observation, but I saw that it has already been submitted.
Good fixes. @stemlaud CC @Olshansk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants