[WIP] Implement historical params with height-based retrieval#1154
Draft
red-0ne wants to merge 1 commit into
Draft
[WIP] Implement historical params with height-based retrieval#1154red-0ne wants to merge 1 commit into
red-0ne wants to merge 1 commit into
Conversation
| // 2a. This likely also requires adding validation to the shared module params. | ||
| blockHeight := ctx.BlockHeight() | ||
|
|
||
| // TODO_IN_THIS_PR: Iterate over all claims and use the sharedParams as of the |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Iterate over all claims and use the sharedParams as of the
| func (sq *sharedQuerier) GetParams(ctx context.Context) (*sharedtypes.Params, error) { | ||
| logger := sq.logger.With("query_client", "shared", "method", "GetParams") | ||
|
|
||
| // TODO_IN_THIS_PR: Ensure that the latest cached version of the shared module |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Ensure that the latest cached version of the shared module
f0ba8c2 to
c24e0ce
Compare
6 tasks
c24e0ce to
3872df9
Compare
3872df9 to
7f7e3d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhance params system to track historical parameters and enable retrieval based on block height.
Delay params activation until next session to avoid disturbing the current session with new params.
Primary Changes:
ParamsCacheinterface to support historical storage withGetAtHeightandSetAtHeightmethodsGetParamsAtHeightquery functionality to retrieve params effective at a specific block heightSecondary changes:
ParamsUpdatestorage with effective block heightsBeginBlockerto activate scheduled param updates at session boundariesIssue
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsSanity Checklist
assignees,reviewers,labels,project,iterationandmilestonemake docusaurus_startmake go_develop_and_testandmake test_e2edevnet-test-e2elabel to run E2E tests in CI