Fix issue of auto save and auto format conflicting.#87
Open
wbjin wants to merge 2 commits into
Open
Conversation
|
Nice find! Would you mind sharing that on https://github.com/okuuva/auto-save.nvim ? It's the more maintained fork (disclaimer, I'm one of the maintainers). |
|
Hey ! If you are using conform.nvim for formatting, there is a new format option called undojoin (see this PR. This option allows you to merge the formatting with the previous edition in the undo history, so that you don't have to care about formatting anymore with autosave. |
vuthanhtung2412
added a commit
to vuthanhtung2412/nvim-config
that referenced
this pull request
Nov 11, 2024
auto format and auto save create a circular loop that mess up undo tree : pocco81/auto-save.nvim#87
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When auto save and auto format is turned on together, undo and redo does not work as expected because of a circular relationship. Consider this situation:
When you try to undo, you will undo the formatting after which auto save will save this undoing. This creates a circular relationship between auto save and auto format causing issues.
Fix this issue by not auto saving on an undo.