Repository navigation
Move lucide-react to devDependencies - #2
Open
gwynnnplaine wants to merge 1 commit into
Open
gwynnnplaine wants to merge 1 commit into
gwynnnplaine wants to merge 1 commit into
Conversation
lucide-react is only imported by examples/basic, which is not published, yet it was a runtime dependency, so every install of the package pulled in its 3,940 files. The core and server entry points need only node-pty and ws. A cold npm install --omit=dev of the packed package drops from 4,677 files (124 MB) to 737 files (79 MB).
Author
|
@backnotprop hey, do you have time to take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I opened a PR in plannotator (backnotprop/plannotator#1621) and noticed the Windows smoke test failed, then passed on re-run. So I dug into why it's flaky.
The failing step was
plannotator install-runtime agent-terminal. It runsnpm install @plannotator/webtuiwith a 120s timeout. Normally it takes 40-85s, but that runner was slower than usual and it hit the limit.Then I noticed the install is 4,677 files, and 3,940 of them are lucide-react. It's only used in examples/basic, which isn't published, but it's listed under dependencies, so everyone gets it. On Windows every extracted file gets scanned, so that's where the time goes.
I moved it to devDependencies. A cold
npm install --omit=devof the packed package:pnpm run checkpasses, the example still builds, and core/server import fine from the packed install.If you don't mind merging this and publishing a patch release, I'll bump the version in plannotator and we can see what CI shows :))
(I used an AI agent to help with this.)