Conversation
…critical bug fixes and an expansion of the unit test suite.
The key changes are:
1. **Fix Font Loading Bug:**
- Resolved a `FontFormatException` that occurred on startup by wrapping the font resource `InputStream` in a `BufferedInputStream` in `FontManager.java`.
- Added `FontManagerTest.java` to verify the fix and prevent future regressions.
2. **Add New Unit Tests for PackageManager:**
- Added a test to ensure an `IOException` is thrown when attempting to add a file that exceeds the maximum size limit.
- Added tests to verify that the `isModified` flag is correctly set after `updateAssetContent`, `updateAssetMeta`, and `removeDirectory` operations. This improves the reliability of the unsaved changes tracking.
3. **Refactor for Testability:**
- Refactored `PackageManager` to allow its max asset size limit to be configurable via a new constructor, making the size-limit logic testable without using reflection.
4. **Fix Checkstyle and Build Issues:**
- Addressed numerous checkstyle warnings throughout the codebase, including replacing wildcard imports, fixing naming conventions, and adding missing braces.
- Resolved several compilation and formatting errors that were discovered during the development process.
…icons for improved UI layout and functionality
…l into AssetViewerFrame
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PackageManagerfunctionalities.