-
Notifications
You must be signed in to change notification settings - Fork 288
[Multi_K8s-Plugin] Prune orphaned resources on rollback #6748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Warashi
merged 15 commits into
pipe-cd:master
from
mohammedfirdouss:feat/multicluster-rollback-pruning
May 29, 2026
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
41df9e4
[Multi_K8s-Plugin] Prune orphaned resources on rollback
mohammedfirdouss ce00220
Merge branch 'master' into feat/multicluster-rollback-pruning
mohammedfirdouss 5e579da
Merge branch 'master' into feat/multicluster-rollback-pruning
mohammedfirdouss 2985a48
Merge branch 'master' into feat/multicluster-rollback-pruning
mohammedfirdouss 335f07d
Merge branch 'master' into feat/multicluster-rollback-pruning
mohammedfirdouss 9d484b0
Merge branch 'master' into feat/multicluster-rollback-pruning
mohammedfirdouss af5e52a
Merge branch 'master' into feat/multicluster-rollback-pruning
mohammedfirdouss 949a564
fix(kubernetes_multicluster): use live resources for rollback pruning
mohammedfirdouss 249bba0
Merge branch 'master' into feat/multicluster-rollback-pruning
mohammedfirdouss b482407
fix(kubernetes_multicluster): fix gofmt formatting in misc_test.go
mohammedfirdouss 762028b
Merge branch 'master' into feat/multicluster-rollback-pruning
mohammedfirdouss b1f3909
Merge branch 'master' into feat/multicluster-rollback-pruning
mohammedfirdouss 63a833f
fix(kubernetes_multicluster): log pruning info when no live resources…
mohammedfirdouss b4b3f95
fix(kubernetes_multicluster): log pruning info when no live resources…
mohammedfirdouss 29bbcb7
Merge branch 'master' into feat/multicluster-rollback-pruning
mohammedfirdouss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to log this info even when
len(namespacedLiveResources)+len(clusterScopedLiveResources) == 0.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mohammedfirdouss This does not seem to be resolved. Please check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint check failed for now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add the log too