Fix removal of existing cloudrun revision tags when deploying

[niladrix719]

I have investigated about the problem,

pipecd/pkg/app/piped/platformprovider/cloudrun/client.go

Lines 94 to 96 in c1ca195

	svc = run.NewNamespacesServicesService(c.client)
	name = makeCloudRunServiceName(c.projectID, sm.Name)
	call = svc.ReplaceService(name, svcCfg)

The issue was that when calling svc.ReplaceService(name, svcCfg), the tags associated with revisions in the traffic configuration were being lost.

To fix this, we can retrieve the current service configuration, extracts the existing revision tags from its traffic configuration, and then copy these tags to the corresponding revisions in the new service configuration before calling ReplaceService.

But still, the tags of outdated revisions would be removed, as we are only keeping track of the new revision and the last deployed revision.

pipecd/pkg/app/piped/executor/cloudrun/deploy.go

Lines 188 to 197 in c1ca195

	traffics := []provider.RevisionTraffic{
	{
	RevisionName: revision,
	Percent: options.Percent.Int(),
	},
	{
	RevisionName: lastDeployedRevision,
	Percent: 100 - options.Percent.Int(),
	},
	}

To solve this, we can mark the outdated revisions that have tags with 0% traffic, so it can replicate the behavior seen in Cloud Run

What this PR does:

• Fixes the removal of existing Cloud Run revision tags during deployment
• Adds tests for the new functionality

Why we need it:

Revision tags created by the user should not be removed

Which issue(s) this PR fixes:

Fixes #4954

Does this PR introduce a user-facing change?: No

• How are users affected by this change: No
• Is this breaking change: No
• How to migrate (if breaking change): No

[github-actions]

@niladrix719
Thank you for your contribution! We look forward to seeing more from you.
Please run the make check command to ensure your changes will pass the CI.
After successfully running the command on your local machine, the instructions will be printed out.
Please follow them to commit your changes.
If the check has not passed, please fix the issues and push the changes to your branch.
Then, please run the make check command again to ensure the issues are fixed.

[niladrix719]

/check-commit f944fdff91e0f94d15656571aa3dc07df9b40949c4e8e8850fbf09d3a301d105

[t-kikuc]

@niladrix719
Hi, Thank you so much.

At first, I recommend you split into functions and add tests.

[niladrix719]

Test cases and splitting function are done. Let me know if there is anything else

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[khanhtc1202]

Let's me hold this one and try add this while implementing the CloudRun plugin 👀

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable.