Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @sary8. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. 📝 WalkthroughWalkthroughThe documentation renames two ChangesConfiguration Name Update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The PR is mergeable; the pre-existing v7.5 and v8.5 documentation anchors should be fixed separately. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: pingcap/docs/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 54ddae6b-fe0a-41ca-89d3-481a26a0d22d
📒 Files selected for processing (2)
dynamic-config.mdtikv-configuration-file.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
What is changed, added, or deleted? (Required)
The
gc.auto-compactionoptionstombstone-num-thresholdandtombstone-percent-thresholdare documented with the wrong names. TiKV usestombstones-num-thresholdandtombstones-percent-threshold.The documented names are rejected by
--config-checkand are not applied during normal startup.This PR:
tikv-configuration-file.mdanddynamic-config.mdWhich TiDB version(s) do your changes apply to? (Required)
The same spelling is present in
release-8.5andrelease-7.5.What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit