Skip to content

docs: document TiFlash NullEQ pushdown - #23926

Open
windtalker wants to merge 1 commit into
pingcap:masterfrom
windtalker:tiflash_support_nulleq
Open

windtalker wants to merge 1 commit into
pingcap:masterfrom
windtalker:tiflash_support_nulleq

Conversation

@windtalker

@windtalker windtalker commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

What is changed, added, or deleted? (Required)

Document that TiFlash supports pushing down the NULL-safe equality operator (<=>) as an expression and as an equi-join condition for MPP HashJoin.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after being applied to another branch

Summary by CodeRabbit

  • Documentation
    • Clarified the supported join types for pushdown calculations, including NULL-safe equi joins and specific non-equi joins.
    • Added the <=> operator to the documented list of supported numeric functions and operators.

@ti-chi-bot

ti-chi-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tangenta for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2026
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingcap/docs/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c5b8d63f-711a-43fb-b682-f4267c3b8035

📥 Commits

Reviewing files that changed from the base of the PR and between a343636 and 6beea2a.

📒 Files selected for processing (1)
  • tiflash/tiflash-supported-pushdown-calculations.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The TiFlash pushdown documentation now lists NULL-safe equi joins using <=> and includes <=> in the supported numeric functions and operators.

Changes

TiFlash pushdown documentation

Layer / File(s) Summary
Document join and operator support
tiflash/tiflash-supported-pushdown-calculations.md
The HashJoin conditions now include NULL-safe Equi Join using <=>. The supported numeric functions and operators now include <=>.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description includes the required change summary, affected version, related code PR, AI involvement, and change-category checklist. It is complete and relevant.
Title check ✅ Passed The title clearly and concisely identifies the documentation change for TiFlash NULL-safe equality pushdown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@windtalker windtalker added the needs-cherry-pick-release-nextgen-202609 Should cherry pick this PR to release-nextgen-202609 branch. label Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-nextgen-202609 Should cherry pick this PR to release-nextgen-202609 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant