Add LibreDB Studio to the list of supported GUI tools - #23658
kaya-abdullah wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @kaya-abdullah. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @kaya-abdullah! |
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. 📝 WalkthroughWalkthroughThe GUI support table now lists LibreDB Studio, tested with version 0.16.2. The entry marks support as Full and indicates that no tutorial is available. ChangesGUI support documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: 🔵 Low · up to The entry may overstate LibreDB Studio coverage; use Compatible or document broader testing. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @qiancai, this PR has been open for about two weeks and is still waiting on a pingcap member to comment /ok-to-test so CI can run. Could you or someone else on the team take a look? Happy to address any feedback. |
|
Hi @qiancai, checking back on this one again. It has been about two weeks since the last note and it is still waiting on /ok-to-test. Let me know if there is anything I can do to help move it along. |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: pingcap/docs/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: a583177e-5344-47a4-8174-f8072c6a6527
📒 Files selected for processing (1)
develop/dev-guide-third-party-support.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
| | [DBeaver](https://dbeaver.io/) | 23.0.3 | Full | [Connect to TiDB with DBeaver](/develop/dev-guide-gui-dbeaver.md) | | ||
| | [Visual Studio Code](https://code.visualstudio.com/) | 1.72.0 | Full | [Connect to TiDB with Visual Studio Code](/develop/dev-guide-gui-vscode-sqltools.md) | | ||
| | [Navicat](https://www.navicat.com) | 17.1.6 | Full | [Connect to TiDB with Navicat](/develop/dev-guide-gui-navicat.md) | | ||
| | [LibreDB Studio](https://libredb.org) | 0.16.2 | Full | N/A | |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
rg -n -C 8 'Full|Compatible|LibreDB|support|functionalit|testing' develop/dev-guide-third-party-support.md
sed -n '1,100p' develop/dev-guide-third-party-support.mdRepository: pingcap/docs
Length of output: 15564
🏁 Script executed:
#!/bin/bash
set -o pipefail
printf '%s\n' '--- diff stat ---'
git diff --stat
printf '%s\n' '--- focused diff ---'
git diff -- develop/dev-guide-third-party-support.md
printf '%s\n' '--- LibreDB references ---'
rg -n -i -C 3 'libredb|libredb studio' .
printf '%s\n' '--- reported check terms ---'
rg -n -i -C 2 'connection|query execution|table creation|row reads|compatibility test|latest version|ongoing' --glob '*.md' --glob '*.yml' --glob '*.yaml' --glob '*.json' . | head -250Repository: pingcap/docs
Length of output: 27450
Use Compatible unless broader coverage and ongoing testing are documented.
Full requires compatibility with most functionalities and periodic tests against the latest version. The four reported checks do not establish that contract.
Suggested replacement
| | [LibreDB Studio](https://libredb.org) | 0.16.2 | Full | N/A | | |
| | [LibreDB Studio](https://libredb.org) | 0.16.2 | Compatible | N/A | |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Adds LibreDB Studio (https://libredb.org, https://github.com/libredb/libredb-studio) to the GUI table in the third-party tools list. It's an open-source, web-based SQL IDE that connects to TiDB over the MySQL protocol.
Verified against a local TiDB Self-Managed instance (
pingcap/tidb:v8.5.0,--store=unistore): created a connection, ran a query, created a table and read the rows back.The Full rating reflects a broader measurement than that single session: the TiDB section of docs/providers/mysql.md in the LibreDB Studio repo independently tests all 15 provider surfaces against TiDB (schema browsing, query editing, EXPLAIN, health/monitoring, storage stats, permissions, and more) and documents the caveats found: background statistics lag on freshly loaded tables,
EXPLAIN FORMAT='json'being rejected, an empty slow-query panel, and a phantom InnoDB storage entry.A dedicated connection tutorial (like the ones DataGrip, DBeaver, VS Code and Navicat have) is not included in this PR, so the Tutorial column is
N/Afor now, same as the Beekeeper Studio row above it.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit