Skip to content

Fix stale versioned docs links#22875

Open
tdashelby-cmyk wants to merge 2 commits into
pingcap:masterfrom
tdashelby-cmyk:fix-stale-doc-links-22867
Open

Fix stale versioned docs links#22875
tdashelby-cmyk wants to merge 2 commits into
pingcap:masterfrom
tdashelby-cmyk:fix-stale-doc-links-22867

Conversation

@tdashelby-cmyk
Copy link
Copy Markdown

What changed

This PR updates stale documentation links reported in #22867:

  • Moves versioned TiDB v7.2, v7.6, and v8.3 links to docs-archive.pingcap.com, preserving the original versioned targets.
  • Updates the TiDB Cloud Starter TLS link to the current secure-connections-to-serverless-clusters page.
  • Removes the broken TiDB roadmap hyperlink from the TiDB Cloud roadmap page because the linked docs page no longer exists in the current docs site.

Verification

  • rg -n https://docs\\.pingcap\\.com/tidb/v(7\\.2|7\\.6|8\\.3)/|https://docs\\.pingcap\\.com/tidbcloud/secure-connections-to-starter-clusters/|https://docs\\.pingcap\\.com/tidb/dev/tidb-roadmap -g *.md returns no matches.
  • Checked each new external URL introduced in the diff with Invoke-WebRequest; all returned HTTP 200.
  • git diff --check
  • npx --yes markdownlint-cli@0.17.0 <changed files>

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 11, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 11, 2026

Welcome @tdashelby-cmyk!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 11, 2026

Hi @tdashelby-cmyk. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pingcap-cla-assistant
Copy link
Copy Markdown

pingcap-cla-assistant Bot commented May 11, 2026

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 11, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates numerous documentation links to point to the archived documentation site (docs-archive.pingcap.com), ensures consistent trailing slashes, and corrects several link anchors across various files. Feedback includes a suggestion to remove a roadmap section that is no longer informative after its link was removed and a correction for a specific link anchor to maintain consistency with documentation standards.

Comment thread tidb-cloud/tidb-cloud-roadmap.md Outdated
Comment on lines +74 to +76
## TiDB kernel

For the roadmap of TiDB kernel, refer to [TiDB Roadmap](https://docs.pingcap.com/tidb/dev/tidb-roadmap).
For the roadmap of TiDB kernel, refer to TiDB Roadmap.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Since the link to the TiDB kernel roadmap has been removed, this section is no longer informative. To avoid confusion, I suggest removing this 'TiDB kernel' section entirely.

Comment thread tiflash/tiflash-pipeline-model.md Outdated
Starting from v7.2.0, TiFlash supports a new execution model, the pipeline execution model.

- For v7.2.0 and v7.3.0: The pipeline execution model is experimental and is controlled by [`tidb_enable_tiflash_pipeline_model`](https://docs.pingcap.com/tidb/v7.2/system-variables#tidb_enable_tiflash_pipeline_model-introduced-since-v720).
- For v7.2.0 and v7.3.0: The pipeline execution model is experimental and is controlled by [`tidb_enable_tiflash_pipeline_model`](https://docs-archive.pingcap.com/tidb/v7.2/system-variables/#tidb_enable_tiflash_pipeline_model-introduced-since-v720).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The anchor in this link appears to be incorrect. For consistency with other similar links in the documentation, it should be ...-new-in-v720 instead of ...-introduced-since-v720.

Suggested change
- For v7.2.0 and v7.3.0: The pipeline execution model is experimental and is controlled by [`tidb_enable_tiflash_pipeline_model`](https://docs-archive.pingcap.com/tidb/v7.2/system-variables/#tidb_enable_tiflash_pipeline_model-introduced-since-v720).
- For v7.2.0 and v7.3.0: The pipeline execution model is experimental and is controlled by [`tidb_enable_tiflash_pipeline_model`](https://docs-archive.pingcap.com/tidb/v7.2/system-variables/#tidb_enable_tiflash_pipeline_model-new-in-v720).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant