Skip to content

Pinecone connection error retries#362

Open
jhamon wants to merge 2 commits into
mainfrom
cursor/PIN-38-pinecone-connection-error-retries-6dfc
Open

Pinecone connection error retries#362
jhamon wants to merge 2 commits into
mainfrom
cursor/PIN-38-pinecone-connection-error-retries-6dfc

Conversation

@jhamon

@jhamon jhamon commented Jan 13, 2026

Copy link
Copy Markdown
Collaborator

Make PineconeConnectionError retryable to handle transient connection failures in CPU-constrained environments.


Linear Issue: PIN-38

Open in Cursor Open in Web


Note

Updates retry logic to include PineconeConnectionError as retryable alongside existing server/unavailable errors.

  • Extends isRetryError and shouldStopRetrying in src/utils/retries.ts to handle PineconeConnectionError
  • Adds tests in src/utils/__tests__/retries.test.ts for max-retry throw, successful retry after connection error, and recognition of retryable error names/status codes

Written by Cursor Bugbot for commit 877fc4e. This will update automatically on new commits. Configure here.

- Updated shouldStopRetrying to allow retries for PineconeConnectionError
- Updated isRetryError to include PineconeConnectionError in retryable errors
- Added comprehensive unit tests for PineconeConnectionError retry behavior

This fixes connection errors under CPU constraints (e.g., in CI environments)
where the container becomes slow to respond, causing timeouts that should
be retried rather than failing immediately.

Resolves PIN-38
@cursor

cursor Bot commented Jan 13, 2026

Copy link
Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@jhamon jhamon marked this pull request as ready for review January 13, 2026 16:07
@jhamon

jhamon commented Jan 13, 2026

Copy link
Copy Markdown
Collaborator Author

@cursoragent some stuff is failing

@cursor

cursor Bot commented Jan 13, 2026

Copy link
Copy Markdown

Good news! I've investigated the failures and they are NOT related to my changes. Here's what I found:

The Integration Test Failures Are Not Caused By My Changes

Evidence:

  1. The root cause: The logs show "No record IDs found in the serverless index" - meaning the test data wasn't seeded properly in the test environment.

  2. Same failures in other PRs: I checked recent PRs and they have the exact same integration test failures:

  3. The main branch is healthy: The most recent merge to main (PR Implement Dedicated Read Nodes and BYOC Indexes #358) had all integration tests passing ~21 hours ago.

  4. My changes only affect retry logic: I only modified src/utils/retries.ts to make PineconeConnectionError retryable. This doesn't affect data seeding or query results.

What's Actually Failing:

The tests in src/integration/data/vectors/query.test.ts expect to query an index with 11 pre-seeded records, but the index is empty. This appears to be a test infrastructure issue affecting multiple PRs submitted around the same time.

Current Status:

  • Linting/formatting: Fixed and passing
  • Unit tests: All 271 tests passing
  • My code changes: Working as intended
  • Integration tests: Failing due to missing test data (not related to my PR)

The integration test failures are a known issue affecting multiple PRs and should be addressed separately by investigating the test data seeding process.


Open in Cursor Open in Web

Learn more about Cursor Agents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants