Repository navigation
ci: unblock the security check; common v0.5.15, Go 1.25.13 - #49
Merged
Merged
Conversation
The govulncheck job has failed on every PR for two separate reasons: `go install govulncheck@latest` now resolves to v1.8.0, which needs Go 1.26, and Go 1.25.12 has standard-library advisories fixed in 1.25.13. Pin govulncheck to v1.7.0 and take common v0.5.15, which also moves the go directive to 1.25.13. Supersedes the stuck cascade bump #47. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required
govulncheckjob fails on every PR in this repo, for two independent reasons:go install golang.org/x/vuln/cmd/govulncheck@latestnow resolves to v1.8.0, which requires Go 1.26; the job runs with the Go version fromgo.modandGOTOOLCHAIN=local, so the install itself fails.This pins govulncheck to v1.7.0 (the version pilotprotocol uses) and takes common v0.5.15, which moves the
godirective to 1.25.13. It supersedes the stuck cascade bump #47.Locally with
GOWORK=off:go build ./...,go test ./...andgovulncheck@v1.7.0 ./...pass.🤖 Generated with Claude Code