Repository navigation
fix: allow concurrent exec sessions - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the environment lock from
ocdev execso multiple long-running commands can run in the same container. Previously, one exec session prevented another from starting and blocked lifecycle operations that used the same lock.What changed
Behavior and safety
Exec no longer coordinates with setup or teardown. Stop/delete can interrupt running commands. The preflight checks are not atomic with execution by name, so a container can stop or be replaced between the check and execution.
Signal handling, separate output streams, exit-code forwarding, and client cleanup are unchanged.
Testing
make test-exec: all 15 test groups passed, including concurrent plain/recipe sessions, independent completion and cancellation, and execution while lifecycle locks are held.make test: all 117 tests plus version regressions passed with a clean HOME and a PATH without Python or real Incus.