Skip to content

Updating ffmpeg binaries to 4.2.1#1

Open
yafp wants to merge 7 commits into
pietrop:masterfrom
yafp:master
Open

Updating ffmpeg binaries to 4.2.1#1
yafp wants to merge 7 commits into
pietrop:masterfrom
yafp:master

Conversation

@yafp

@yafp yafp commented Dec 10, 2019

Copy link
Copy Markdown

I downloaded the ffmpeg 4.2.1 binaries for

  • win32
  • win64
  • mac64
  • linux32
  • linux64

and replaced your old versions with it.
No other changes made.
URL sources are provided with the single commits.

Changes are not tested but i hope this helps updating your nice project.

Sideeffect:
Version 4.2.1 seems a lot bigger than the 3.x versions you are currently using.

@pietrop

pietrop commented Dec 13, 2019

Copy link
Copy Markdown
Owner

Thanks, I'll see if I can make some time to test it out (at least the mac version) before merging.

Where did you download the binaries from?

I was also looking at your issue yafp/media-dupes#22 and that's an excellent point re size of the repository over time, by committing binaries into it.

I run into a similar problem in another repository where I wrote this ADR to explore some options

if the binaries are from github releases of some other repository could follow option "5. npm pre install with wget"

@yafp

yafp commented Dec 13, 2019

Copy link
Copy Markdown
Author

Hi @pietrop

regarding your question:

I used the source urls which you provided in your project readme.md
I've added the urls for each binary to the commit messages (open by clicking ...) - to make it as clear as possible

@pietrop

pietrop commented Dec 13, 2019

Copy link
Copy Markdown
Owner

Awesome, thank you soo much @yafp !

@yafp

yafp commented Dec 13, 2019

Copy link
Copy Markdown
Author

@pietrop
Regarding having not all 5 binaries in the builds .... i guess i found a pretty easy solution. Its not fully tested so far but it seems to work.

It's about adding a files section to the platform specific section of your package.json. This can be used to ignore some path while running electron-builder.

See yafp/media-dupes#22 for an example

@pietrop

pietrop commented Dec 13, 2019

Copy link
Copy Markdown
Owner

@yafp yes, exactly! that's what I described in this blog post which is how I did it in autoEdit and BBC Digital Paper Edit (Electron)

@yafp

yafp commented Jan 24, 2020

Copy link
Copy Markdown
Author

@pietrop
any chance you already played around with those updated binaries?

@derhuerst

Copy link
Copy Markdown

Let's solve this upstream! See also eugeneware#35 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants