Updating ffmpeg binaries to 4.2.1#1
Conversation
|
Thanks, I'll see if I can make some time to test it out (at least the mac version) before merging. Where did you download the binaries from? I was also looking at your issue yafp/media-dupes#22 and that's an excellent point re size of the repository over time, by committing binaries into it. I run into a similar problem in another repository where I wrote this ADR to explore some options if the binaries are from github releases of some other repository could follow option "5. npm pre install with wget" |
|
Hi @pietrop regarding your question: I used the source urls which you provided in your project readme.md |
|
Awesome, thank you soo much @yafp ! |
|
@pietrop It's about adding a files section to the platform specific section of your package.json. This can be used to ignore some path while running electron-builder. See yafp/media-dupes#22 for an example |
|
@yafp yes, exactly! that's what I described in this blog post which is how I did it in autoEdit and BBC Digital Paper Edit (Electron) |
|
@pietrop |
|
Let's solve this upstream! See also eugeneware#35 . |
I downloaded the ffmpeg 4.2.1 binaries for
and replaced your old versions with it.
No other changes made.
URL sources are provided with the single commits.
Changes are not tested but i hope this helps updating your nice project.
Sideeffect:
Version 4.2.1 seems a lot bigger than the 3.x versions you are currently using.