fix: correctly identify ondemand challenges to prune#71
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates pruning behavior to correctly target on-demand (“dynamic”) challenge instances by selecting builds based on instancecount == DYNAMIC_INSTANCES rather than relying on a schema name prefix, and updates/extends tests accordingly.
Changes:
- Update
Manager.Prune()to delete old instances by filtering onbuilds.instancecount == DYNAMIC_INSTANCES(instead ofschema LIKE "manual-%"). - Refactor prune tests to parameterize build
InstanceCountand validate dynamic vs fixed-pool behavior. - Add a test ensuring age-based pruning releases reserved ports via
ON DELETE CASCADE.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
cmgr/prune_test.go |
Updates fixtures/tests to validate pruning selection by instance count and adds port-release coverage. |
cmgr/api.go |
Changes pruning SQL filter to target on-demand builds by instancecount. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.