Do not accept raw ObjectType in intersection as GenericObjectType<TemplateType>#5926
Merged
Merged
Conversation
ondrejmirtes
requested changes
Jun 24, 2026
rvanvelzen
force-pushed
the
bug-13190-extra
branch
from
9a46610 to
f53b968
Compare
Member
|
Please check these changes https://github.com/phpstan/phpstan-src/actions/runs/28099136495 and evaluate how valid they are |
rvanvelzen
force-pushed
the
bug-13190-extra
branch
from
f53b968 to
ec56d11
Compare
Closes phpstan/phpstan#13190 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rvanvelzen
force-pushed
the
bug-13190-extra
branch
from
ec56d11 to
4dc5cb6
Compare
Contributor
Author
|
I just love how covering the test suite is. You guys are doing a great job 💪 |
ondrejmirtes
approved these changes
Jun 24, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13190. My previous PR did fix an issue in there but not the actual bug that was reported.
In general AI works wonders but sometimes it strays too much and I didn't catch it this time. Sorry!