Skip to content

[Sync-EN] Document the procedural style of IntlGregorianCalendar methods - #1797

Merged
mmalferov merged 5 commits into
php:masterfrom
lacatoire:sync-en/1656
Nov 20, 2026
Merged

mmalferov merged 5 commits into
php:masterfrom
lacatoire:sync-en/1656

Conversation

@lacatoire

@lacatoire lacatoire commented Aug 31, 2026 •

Copy link
Copy Markdown
Member

Syncs the three reference/intl/intlgregoriancalendar/ pages with php/doc-en#5619.

The three pages carried an empty description with &warn.undocumented.func;. They now document both styles and the behaviour:

  • getGregorianChange() / intlgregcal_get_gregorian_change(): the Gregorian change date, the point at which the calendar switches from Julian to Gregorian dates, as a Unix timestamp in milliseconds, defaulting to midnight UTC on 15 October 1582.
  • isLeapYear() / intlgregcal_is_leap_year(): whether the given year is a leap year in the Gregorian calendar, with the year parameter finally described.
  • setGregorianChange() / intlgregcal_set_gregorian_change(): sets that date, with timestamp described.

Each page gains the &style.oop; and &style.procedural; markers and the calendar parameter of the procedural form.

Also reworded the return values of isLeapYear() and getGregorianChange() to match the glossary.

EN-Revision bumped to a9a5a377cfbff431de8bbdca1a2b7a51c7500ca1 on the three files.

Fixes: #1656

@mmalferov
mmalferov merged commit f7c61dc into php:master Nov 20, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sync EN] intl: document the procedural style of IntlGregorianCalendar methods

2 participants