Skip to content
This repository was archived by the owner on Feb 26, 2026. It is now read-only.

retrieve n addresses starting from next unused index#36

Open
xsats wants to merge 10 commits into
photon-sdk:masterfrom
xsats:features/getmultipleaddresses
Open

retrieve n addresses starting from next unused index#36
xsats wants to merge 10 commits into
photon-sdk:masterfrom
xsats:features/getmultipleaddresses

Conversation

@xsats

@xsats xsats commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@tanx tanx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one comment. Also looks like the package-lock.json is conflicting after merging the other PR to the master.

return nextFreeAddresses;
}
// return object: [{ index: "", address: ""}, ...]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from async getAddressAsync() right above it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function returns n addresses starting from the next unused address retrieved by getAddressAsync(). I suppose the looping could just happen on the app side but I think it's a useful minor addition to the library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants