v.4 to v.5.1.4 update

[shenyman]

There is only master branch and no v.4 branch, as mentioned in the readme NOTE. You may create one or merge and update the vokuro.

[niden]

@shenyman can you please check phpcs for the PermissionsController?

[shenyman]

@shenyman can you please check phpcs for the PermissionsController?

Apologies! Won't PR without phpcs checks anymore!

[niden]

I am sure there is a way to PR my fork, but don't do it since you did a lot of work on this one already. Let's get this done with tests passing and then we can see stuff that we might want to change from the other PR etc.

[shenyman]

@niden Thanks for your patience! I fixed many things using your #165. I think we can do the PR as you suggested. Can you try the tests please? Thank you!

[shenyman]

@niden, in your PR #165, you have a commit af30873 where most of the enhancements are related to removing link_to and adding a tag.a (TagFactory). Because I'm installing Vokuro in a subfolder, I noticed that the main links became 'localhost/vokuro/users/users' after an action. Is this because tag.a does not resolve, and should not resolve by design, the correct URL as link_to does?

I've added 'url' resolver to layouts/private.volt only and committed. Not sure if this is the correct way.

[shenyman]

@niden can we try the tests one more time?